imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Notifications: inline error message on notifications saving error (#10288)

Browse source 
* basic sync setup

* formatting

* get loudest value for synced rules

* more types

* test synced rules in notifications settings

* type fixes

* noimplicitany fixes

* remove debug

* tidying

* extract updatePushRuleActions fn to utils

* extract update synced rules

* just synchronise in one place?

* monitor account data changes AND trigger changes sync in notifications form

* lint

* setup LoggedInView test with enough mocks

* test rule syncing in LoggedInView

* strict fixes

* more comments

* one more comment

* add error variant for caption component

* tests for new error message

* tweak styles

* noImplicitAny

* revert out of date prettier changes to unrelated files

* limit inline message to radios only, tests

* strict fix
This commit is contained in:
Kerry 2023-03-14 10:59:04 +13:00 • committed by GitHub
parent 72404d7216
commit 9f66082486
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 233 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/components/views/typography/Caption-test.tsx
View file

@ -31,6 +31,11 @@ describe("<Caption />", () => {
expect({ container }).toMatchSnapshot();
});
it("renders an error message", () => {
const { container } = render(getComponent({ isError: true }));
expect({ container }).toMatchSnapshot();
});
it("renders react children", () => {
const children = (
<>