Use semantic headings in user settings - discovery (#10838)

* allow testids in settings sections

* use semantic headings in LabsUserSettingsTab

* put back margin var

* use SettingsTab wrapper

* use semantic headings for deactivate acc section

* use semantic heading in manage integratios

* i18n

* use currentColor in warning-triangle svg, update use in RoomStatusBar

* use semantic headings for discovery section

* test manage integration settings

* test deactivate account section display

* remove SettingsFieldset margins

* threepids styles

* remove debug

* test discovery email and phone

res/css/structures/_RoomStatusBar.pcss

@@ -160,7 +160,7 @@ limitations under the License.
     }
 }
 
-.mx_RoomStatusBar_connectionLostBar img {
+.mx_RoomStatusBar_connectionLostBar svg {
     padding-left: 10px;
     padding-right: 10px;
     vertical-align: middle;

res/css/views/settings/_SetIdServer.pcss

@@ -1,5 +1,5 @@
 /*
-Copyright 2019 The Matrix.org Foundation C.I.C.
+Copyright 2019, 2023 The Matrix.org Foundation C.I.C.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -14,8 +14,16 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-.mx_SetIdServer .mx_Field_input {
-    margin-inline-end: var(--SettingsTab_fullWidthField-margin-inline-end);
+.mx_SetIdServer {
+    display: flex;
+    flex-direction: column;
+    align-items: flex-start;
+    gap: $spacing-8;
+
+    .mx_Field {
+        width: 100%;
+        margin: 0;
+    }
 }
 
 .mx_SetIdServer_tooltip {

res/css/views/settings/_SettingsFieldset.pcss

@@ -15,7 +15,6 @@ limitations under the License.
 */
 
 .mx_SettingsFieldset {
-    margin: 10px 80px 10px 0;
     box-sizing: content-box;
 }
 
@@ -31,8 +30,6 @@ limitations under the License.
 }
 
 .mx_SettingsFieldset_description {
-    color: $settings-subsection-fg-color;
-    font-size: $font-14px;
     display: block;
     margin-top: 0;
     margin-bottom: 10px;

res/css/views/settings/tabs/user/_GeneralUserSettingsTab.pcss

@@ -61,6 +61,8 @@ limitations under the License.
     margin-left: 5px;
 }
 
-.mx_GeneralUserSettingsTab_heading_warningIcon {
+.mx_GeneralUserSettingsTab_warningIcon {
     vertical-align: middle;
+    margin-right: $spacing-8;
+    margin-bottom: 2px;
 }

res/img/feather-customised/warning-triangle.svg

@@ -3,7 +3,7 @@
 <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
 	 viewBox="0 0 14 12" style="enable-background:new 0 0 14 12;" xml:space="preserve">
 <style type="text/css">
-	.st0{fill:none;stroke:#454545;stroke-linecap:round;stroke-linejoin:round;}
+	.st0{fill:none;stroke:currentColor;stroke-linecap:round;stroke-linejoin:round;}
 </style>
 <g>
 	<path class="st0" d="M6,1.5L1.2,9.3c-0.2,0.3-0.2,0.8,0,1.1c0.2,0.3,0.6,0.6,1,0.6h9.7c0.4,0,0.8-0.2,1-0.6c0.2-0.3,0.2-0.8,0-1.1