Tooltip: improve accessibility of the right panel (#12490)

* Move to `AccessibleButton`

* Update snapshots

* Update playwright snapshots
This commit is contained in:
Florian Duros 2024-05-03 10:44:04 +02:00 committed by GitHub
parent 3059b5b1e2
commit 95ee2979c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 11 additions and 12 deletions

View file

@ -21,9 +21,7 @@ limitations under the License.
import React, { ReactNode } from "react";
import classNames from "classnames";
import AccessibleTooltipButton from "../elements/AccessibleTooltipButton";
import { ButtonEvent } from "../elements/AccessibleButton";
import { Alignment } from "../elements/Tooltip";
import AccessibleButton, { ButtonEvent } from "../elements/AccessibleButton";
interface IProps {
// Whether this button is highlighted
@ -52,11 +50,11 @@ export default class HeaderButton extends React.Component<IProps> {
});
return (
<AccessibleTooltipButton
<AccessibleButton
{...props}
aria-current={isHighlighted ? "true" : "false"}
title={title}
alignment={Alignment.Bottom}
placement="bottom"
className={classes}
onClick={onClick}
/>

View file

@ -49,7 +49,6 @@ import WidgetUtils from "../../../utils/WidgetUtils";
import { IntegrationManagers } from "../../../integrations/IntegrationManagers";
import SettingsStore from "../../../settings/SettingsStore";
import WidgetAvatar from "../avatars/WidgetAvatar";
import AccessibleTooltipButton from "../elements/AccessibleTooltipButton";
import WidgetStore, { IApp } from "../../../stores/WidgetStore";
import { E2EStatus } from "../../../utils/ShieldUtils";
import { RoomPermalinkCreator } from "../../../utils/permalinks/Permalinks";
@ -184,18 +183,17 @@ const AppRow: React.FC<IAppRowProps> = ({ app, room }) => {
return (
<div className={classes} ref={handle}>
<AccessibleTooltipButton
<AccessibleButton
className="mx_RoomSummaryCard_icon_app"
onClick={onOpenWidgetClick}
// only show a tooltip if the widget is pinned
title={openTitle}
forceHide={!(isPinned || isMaximised)}
title={!(isPinned || isMaximised) ? undefined : openTitle}
disabled={isPinned || isMaximised}
>
<WidgetAvatar app={app} size="20px" />
<span>{name}</span>
{subtitle}
</AccessibleTooltipButton>
</AccessibleButton>
{canModifyWidget && (
<ContextMenuTooltipButton
@ -206,13 +204,13 @@ const AppRow: React.FC<IAppRowProps> = ({ app, room }) => {
/>
)}
<AccessibleTooltipButton
<AccessibleButton
className="mx_RoomSummaryCard_app_pinToggle"
onClick={togglePin}
title={pinTitle}
disabled={cannotPin}
/>
<AccessibleTooltipButton
<AccessibleButton
className="mx_RoomSummaryCard_app_maximiseToggle"
onClick={toggleMaximised}
title={maximiseTitle}