imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Convert UserSettings to functional component (#12474)

Browse source 
* Convert UserSettings to functional component

* Put comment back

* Fix test

* Unused imports
This commit is contained in:
David Baker 2024-04-30 19:52:32 +01:00 • committed by GitHub
parent bb4f57583f
commit 906c9dd948
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/components/views/dialogs/UserSettingsDialog-test.tsx
View file

@ -152,14 +152,17 @@ describe("<UserSettingsDialog />", () => {
watchSettingCallbacks[settingName] = callback;
return `mock-watcher-id-${settingName}`;
});
mockSettingsStore.getValue.mockReturnValue(false);
const { queryByTestId, unmount } = render(getComponent());
expect(queryByTestId(`settings-tab-${UserTab.Mjolnir}`)).toBeFalsy();
expect(mockSettingsStore.watchSetting.mock.calls[0][0]).toEqual("feature_mjolnir");
expect(mockSettingsStore.watchSetting).toHaveBeenCalledWith("feature_mjolnir", null, expect.anything());
// call the watch setting callback
mockSettingsStore.getValue.mockReturnValue(true);
watchSettingCallbacks["feature_mjolnir"]("feature_mjolnir", "", SettingLevel.ACCOUNT, true, true);
// tab is rendered now
expect(queryByTestId(`settings-tab-${UserTab.Mjolnir}`)).toBeTruthy();