switch Tinter from using dispatch to a synchronous update when changing the colourscheme, to avoid CSS getting out of sync with SVG colours

src/components/views/elements/TintableSvg.js

@@ -18,10 +18,9 @@ limitations under the License.
 
 var React = require('react');
 var ReactDOM = require("react-dom");
-var dis = require("../../../dispatcher");
 var Tinter = require("../../../Tinter");
 
-module.exports = React.createClass({
+var TintableSvg = React.createClass({
     displayName: 'TintableSvg',
 
     propTypes: {
@@ -31,28 +30,42 @@ module.exports = React.createClass({
         className: React.PropTypes.string,
     },
 
+    statics: {
+        // list of currently mounted TintableSvgs
+        mounts: {},
+        idSequence: 0,
+    },
+
     componentWillMount: function() {
         this.fixups = [];
-        this.dispatcherRef = dis.register(this.onAction);
     },
 
     componentDidMount: function() {
+        this.id = TintableSvg.idSequence++;
+        TintableSvg.mounts[this.id] = this;
         // we can't use onLoad on object due to https://github.com/facebook/react/pull/5781
         // so handle it with pure DOM instead
         ReactDOM.findDOMNode(this).addEventListener('load', this.onLoad);
     },
 
     componentWillUnmount: function() {
+        delete TintableSvg.mounts[this.id];
         ReactDOM.findDOMNode(this).removeEventListener('load', this.onLoad);
-        dis.unregister(this.dispatcherRef);
     },
 
-    onAction: function(payload) {
-        if (payload.action !== 'tint_update') return;
+    shouldComponentUpdate: function(nextProps, nextState) {
+        // XXX: no dynamic TintableSvgs for now; speed above all else
+        return false;
+    },
+
+    tint: function() {
+        // TODO: only bother running this if the global tint settings have changed
+        // since we loaded!
         Tinter.applySvgFixups(this.fixups);
     },
 
     onLoad: function(event) {
+        // console.log("TintableSvg.onLoad for " + this.props.src);
         this.fixups = Tinter.calcSvgFixups([event.target]);
         Tinter.applySvgFixups(this.fixups);
     },
@@ -67,3 +80,5 @@ module.exports = React.createClass({
         );
     }
 });
+
+module.exports = TintableSvg;