Merge pull request #3139 from matrix-org/travis/upgrades-final

Fix room upgrade warning being chopped off and a spelling mistake

res/css/views/rooms/_RoomUpgradeWarningBar.scss

@@ -15,17 +15,22 @@ limitations under the License.
 */
 
 .mx_RoomUpgradeWarningBar {
+    max-height: 235px;
+    background-color: $preview-bar-bg-color;
+    padding-left: 20px;
+    padding-right: 20px;
+    overflow: scroll;
+}
+
+.mx_RoomUpgradeWarningBar_wrapped {
+    width: 100%;
+    height: 100%;
+    display: flex;
     text-align: center;
-    height: 235px;
-    background-color: $event-selected-color;
     align-items: center;
     flex-direction: column;
     justify-content: center;
-    display: flex;
-    background-color: $preview-bar-bg-color;
     -webkit-align-items: center;
-    padding-left: 20px;
-    padding-right: 20px;
 }
 
 .mx_RoomUpgradeWarningBar_header {

src/components/views/dialogs/RoomUpgradeDialog.js

@@ -92,7 +92,7 @@ export default React.createClass({
                 <p>
                     {_t(
                         "Upgrading this room requires closing down the current " +
-                        "instance of the room and creating a new room it its place. " +
+                        "instance of the room and creating a new room in its place. " +
                         "To give room members the best possible experience, we will:",
                     )}
                 </p>

src/components/views/rooms/RoomUpgradeWarningBar.js

@@ -97,20 +97,22 @@ module.exports = React.createClass({
 
         return (
             <div className="mx_RoomUpgradeWarningBar">
-                <div className="mx_RoomUpgradeWarningBar_header">
+                <div className="mx_RoomUpgradeWarningBar_wrapped">
-                    {_t(
+                    <div className="mx_RoomUpgradeWarningBar_header">
-                        "This room is running room version <roomVersion />, which this homeserver has " +
+                        {_t(
-                        "marked as <i>unstable</i>.",
+                            "This room is running room version <roomVersion />, which this homeserver has " +
-                        {},
+                            "marked as <i>unstable</i>.",
-                        {
+                            {},
-                            "roomVersion": () => <code>{this.props.room.getVersion()}</code>,
+                            {
-                            "i": (sub) => <i>{sub}</i>,
+                                "roomVersion": () => <code>{this.props.room.getVersion()}</code>,
-                        },
+                                "i": (sub) => <i>{sub}</i>,
-                    )}
+                            },
-                </div>
+                        )}
-                {doUpgradeWarnings}
+                    </div>
-                <div className="mx_RoomUpgradeWarningBar_small">
+                    {doUpgradeWarnings}
-                    {_t("Only room administrators will see this warning")}
+                    <div className="mx_RoomUpgradeWarningBar_small">
+                        {_t("Only room administrators will see this warning")}
+                    </div>
                 </div>
             </div>
         );

src/i18n/strings/en_EN.json

@@ -1208,7 +1208,7 @@
     "The room upgrade could not be completed": "The room upgrade could not be completed",
     "Upgrade this room to version %(version)s": "Upgrade this room to version %(version)s",
     "Upgrade Room Version": "Upgrade Room Version",
-    "Upgrading this room requires closing down the current instance of the room and creating a new room it its place. To give room members the best possible experience, we will:": "Upgrading this room requires closing down the current instance of the room and creating a new room it its place. To give room members the best possible experience, we will:",
+    "Upgrading this room requires closing down the current instance of the room and creating a new room in its place. To give room members the best possible experience, we will:": "Upgrading this room requires closing down the current instance of the room and creating a new room in its place. To give room members the best possible experience, we will:",
     "Create a new room with the same name, description and avatar": "Create a new room with the same name, description and avatar",
     "Update any local room aliases to point to the new room": "Update any local room aliases to point to the new room",
     "Stop users from speaking in the old version of the room, and post a message advising users to move to the new room": "Stop users from speaking in the old version of the room, and post a message advising users to move to the new room",