imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make test ID compatible with findByTestId() of Cypress Testing Library (#10617)

Browse source 
'data-test-id' is not discoverable with findByTestId() of Cypress Testing Library.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
This commit is contained in:
Suguru Hirahara 2023-04-17 06:10:11 +00:00 • committed by GitHub
parent daad630827
commit 8a4a584ba0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cypress/e2e/location/location.spec.ts
View file

@ -23,7 +23,7 @@ describe("Location sharing", () => {
let homeserver: HomeserverInstance; let homeserver: HomeserverInstance;
const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => { const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => {
return cy.get(`[data-test-id="share-location-option-${shareType}"]`); return cy.get(`[data-testid="share-location-option-${shareType}"]`);
}; };
const submitShareLocation = (): void => { const submitShareLocation = (): void => {

2
cypress/e2e/threads/threads.spec.ts
View file

@ -392,7 +392,7 @@ describe("Threads", () => {
it("should send location and reply to the location on ThreadView", () => { it("should send location and reply to the location on ThreadView", () => {
// See: location.spec.ts // See: location.spec.ts
const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => { const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => {
return cy.get(`[data-test-id="share-location-option-${shareType}"]`); return cy.get(`[data-testid="share-location-option-${shareType}"]`);
}; };
const submitShareLocation = (): void => { const submitShareLocation = (): void => {
cy.get('[data-testid="location-picker-submit-button"]').click(); cy.get('[data-testid="location-picker-submit-button"]').click();

2
src/components/views/beacon/LiveTimeRemaining.tsx
View file

@ -69,7 +69,7 @@ const LiveTimeRemaining: React.FC<{ beacon: Beacon }> = ({ beacon }) => {
const liveTimeRemaining = _t(`%(timeRemaining)s left`, { timeRemaining }); const liveTimeRemaining = _t(`%(timeRemaining)s left`, { timeRemaining });
return ( return (
<span data-test-id="room-live-share-expiry" className="mx_LiveTimeRemaining"> <span data-testid="room-live-share-expiry" className="mx_LiveTimeRemaining">
{liveTimeRemaining} {liveTimeRemaining}
</span> </span>
); );

6
src/components/views/beacon/OwnBeaconStatus.tsx
View file

@ -57,7 +57,7 @@ const OwnBeaconStatus: React.FC<Props & HTMLProps<HTMLDivElement>> = ({ beacon,
> >
{ownDisplayStatus === BeaconDisplayStatus.Active && ( {ownDisplayStatus === BeaconDisplayStatus.Active && (
<AccessibleButton <AccessibleButton
data-test-id="beacon-status-stop-beacon" data-testid="beacon-status-stop-beacon"
kind="link" kind="link"
// eat events here to avoid 1) the map and 2) reply or thread tiles // eat events here to avoid 1) the map and 2) reply or thread tiles
// moving under the beacon status on stop/retry click // moving under the beacon status on stop/retry click
@ -70,7 +70,7 @@ const OwnBeaconStatus: React.FC<Props & HTMLProps<HTMLDivElement>> = ({ beacon,
)} )}
{hasLocationPublishError && ( {hasLocationPublishError && (
<AccessibleButton <AccessibleButton
data-test-id="beacon-status-reset-wire-error" data-testid="beacon-status-reset-wire-error"
kind="link" kind="link"
// eat events here to avoid 1) the map and 2) reply or thread tiles // eat events here to avoid 1) the map and 2) reply or thread tiles
// moving under the beacon status on stop/retry click // moving under the beacon status on stop/retry click
@ -82,7 +82,7 @@ const OwnBeaconStatus: React.FC<Props & HTMLProps<HTMLDivElement>> = ({ beacon,
)} )}
{hasStopSharingError && ( {hasStopSharingError && (
<AccessibleButton <AccessibleButton
data-test-id="beacon-status-stop-beacon-retry" data-testid="beacon-status-stop-beacon-retry"
kind="link" kind="link"
// eat events here to avoid 1) the map and 2) reply or thread tiles // eat events here to avoid 1) the map and 2) reply or thread tiles
// moving under the beacon status on stop/retry click // moving under the beacon status on stop/retry click

2
src/components/views/dialogs/ExportDialog.tsx
View file

@ -398,7 +398,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
)} )}
</div> </div>
{isExporting ? ( {isExporting ? (
<div data-test-id="export-progress" className="mx_ExportDialog_progress"> <div data-testid="export-progress" className="mx_ExportDialog_progress">
<Spinner w={24} h={24} /> <Spinner w={24} h={24} />
<p>{exportProgressText}</p> <p>{exportProgressText}</p>
<DialogButtons <DialogButtons

2
src/components/views/location/LiveDurationDropdown.tsx
View file

@ -71,7 +71,7 @@ const LiveDurationDropdown: React.FC<Props> = ({ timeout, onChange }) => {
> >
{ {
options.map(({ key, label }) => ( options.map(({ key, label }) => (
<div data-test-id={`live-duration-option-${key}`} key={key}> <div data-testid={`live-duration-option-${key}`} key={key}>
{label} {label}
</div> </div>
)) as NonEmptyArray<ReactElement & { key: string }> )) as NonEmptyArray<ReactElement & { key: string }>

2
src/components/views/location/ShareType.tsx
View file

@ -91,7 +91,7 @@ const ShareType: React.FC<Props> = ({ setShareType, enabledShareTypes }) => {
onClick={() => setShareType(type)} onClick={() => setShareType(type)}
label={labels[type]} label={labels[type]}
shareType={type} shareType={type}
data-test-id={`share-location-option-${type}`} data-testid={`share-location-option-${type}`}
/> />
))} ))}
</div> </div>

2
src/components/views/right_panel/EncryptionInfo.tsx
View file

@ -108,7 +108,7 @@ const EncryptionInfo: React.FC<IProps> = ({
return ( return (
<React.Fragment> <React.Fragment>
<div data-test-id="encryption-info-description" className="mx_UserInfo_container"> <div data-testid="encryption-info-description" className="mx_UserInfo_container">
<h3>{_t("Encryption")}</h3> <h3>{_t("Encryption")}</h3>
{description} {description}
</div> </div>

4
test/components/views/beacon/__snapshots__/BeaconViewDialog-test.tsx.snap
View file

@ -65,14 +65,14 @@ exports[`<BeaconViewDialog /> renders own beacon status when user is live sharin
</span> </span>
<span <span
class="mx_LiveTimeRemaining" class="mx_LiveTimeRemaining"
data-test-id="room-live-share-expiry" data-testid="room-live-share-expiry"
> >
1h left 1h left
</span> </span>
</div> </div>
<div <div
class="mx_AccessibleButton mx_OwnBeaconStatus_button mx_OwnBeaconStatus_destructiveButton mx_AccessibleButton_hasKind mx_AccessibleButton_kind_link" class="mx_AccessibleButton mx_OwnBeaconStatus_button mx_OwnBeaconStatus_destructiveButton mx_AccessibleButton_hasKind mx_AccessibleButton_kind_link"
data-test-id="beacon-status-stop-beacon" data-testid="beacon-status-stop-beacon"
role="button" role="button"
tabindex="0" tabindex="0"
> >

4
test/components/views/beacon/__snapshots__/RoomLiveShareWarning-test.tsx.snap
View file

@ -15,7 +15,7 @@ exports[`<RoomLiveShareWarning /> when user has live beacons and geolocation is
</span> </span>
<span <span
class="mx_LiveTimeRemaining" class="mx_LiveTimeRemaining"
data-test-id="room-live-share-expiry" data-testid="room-live-share-expiry"
> >
1h left 1h left
</span> </span>
@ -46,7 +46,7 @@ exports[`<RoomLiveShareWarning /> when user has live beacons and geolocation is
</span> </span>
<span <span
class="mx_LiveTimeRemaining" class="mx_LiveTimeRemaining"
data-test-id="room-live-share-expiry" data-testid="room-live-share-expiry"
> >
12h left 12h left
</span> </span>

2
test/components/views/location/__snapshots__/LocationPicker-test.tsx.snap
View file

@ -2,7 +2,7 @@
exports[`LocationPicker <LocationPicker /> for Live location share type updates selected duration 1`] = ` exports[`LocationPicker <LocationPicker /> for Live location share type updates selected duration 1`] = `
<div <div
data-test-id="live-duration-option-3600000" data-testid="live-duration-option-3600000"
> >
Share for 1h Share for 1h
</div> </div>