imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

It's called an "Integration Manager" (singular)

Browse source 
Fixes https://github.com/vector-im/riot-web/issues/11256

This was finally annoying me enough to fix it.
This commit is contained in:
Travis Ralston 2019-11-20 20:14:20 -07:00
parent 3391cc0d90
commit 81c9bdd9f3
11 changed files with 46 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/integrations/IntegrationManagerInstance.js
View file

@ -57,19 +57,19 @@ export class IntegrationManagerInstance {
}
async open(room: Room = null, screen: string = null, integrationId: string = null): void {
const IntegrationsManager = sdk.getComponent("views.settings.IntegrationsManager");
const IntegrationManager = sdk.getComponent("views.settings.IntegrationManager");
const dialog = Modal.createTrackedDialog(
'Integration Manager', '', IntegrationsManager,
{loading: true}, 'mx_IntegrationsManager',
'Integration Manager', '', IntegrationManager,
{loading: true}, 'mx_IntegrationManager',
);
const client = this.getScalarClient();
client.setTermsInteractionCallback((policyInfo, agreedUrls) => {
// To avoid visual glitching of two modals stacking briefly, we customise the
// terms dialog sizing when it will appear for the integrations manager so that
// terms dialog sizing when it will appear for the integration manager so that
// it gets the same basic size as the IM's own modal.
return dialogTermsInteractionCallback(
policyInfo, agreedUrls, 'mx_TermsDialog_forIntegrationsManager',
policyInfo, agreedUrls, 'mx_TermsDialog_forIntegrationManager',
);
});
@ -94,8 +94,8 @@ export class IntegrationManagerInstance {
// Close the old dialog and open a new one
dialog.close();
Modal.createTrackedDialog(
'Integration Manager', '', IntegrationsManager,
newProps, 'mx_IntegrationsManager',
'Integration Manager', '', IntegrationManager,
newProps, 'mx_IntegrationManager',
);
}
}

7
src/integrations/IntegrationManagers.js
View file

@ -172,11 +172,10 @@ export class IntegrationManagers {
}
openNoManagerDialog(): void {
// TODO: Is it Integrations (plural) or Integration (singular). Singular is easier spoken.
const IntegrationsManager = sdk.getComponent("views.settings.IntegrationsManager");
const IntegrationManager = sdk.getComponent("views.settings.IntegrationManager");
Modal.createTrackedDialog(
"Integration Manager", "None", IntegrationsManager,
{configured: false}, 'mx_IntegrationsManager',
"Integration Manager", "None", IntegrationManager,
{configured: false}, 'mx_IntegrationManager',
);
}