imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix clicking on home all rooms space notification not working (#11337)

Browse source 
* Fix clicking on home all rooms space notification not working

* Add test
This commit is contained in:
Michael Telatynski 2023-08-02 10:55:49 +01:00 • committed by GitHub
parent e6bf67ae8b
commit 8166306e0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 50 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

31
test/stores/SpaceStore-test.ts
View file

@ -20,7 +20,7 @@ import { EventType } from "matrix-js-sdk/src/@types/event";
import { RoomMember } from "matrix-js-sdk/src/models/room-member";
import { RoomStateEvent } from "matrix-js-sdk/src/models/room-state";
import { defer } from "matrix-js-sdk/src/utils";
import { ClientEvent, RoomEvent, MatrixEvent, Room } from "matrix-js-sdk/src/matrix";
import { ClientEvent, MatrixEvent, Room, RoomEvent } from "matrix-js-sdk/src/matrix";
import SpaceStore from "../../src/stores/spaces/SpaceStore";
import {
@ -38,6 +38,10 @@ import SettingsStore from "../../src/settings/SettingsStore";
import { SettingLevel } from "../../src/settings/SettingLevel";
import { Action } from "../../src/dispatcher/actions";
import { MatrixClientPeg } from "../../src/MatrixClientPeg";
import RoomListStore from "../../src/stores/room-list/RoomListStore";
import { DefaultTagID } from "../../src/stores/room-list/models";
import { RoomNotificationStateStore } from "../../src/stores/notifications/RoomNotificationStateStore";
import { NotificationColor } from "../../src/stores/notifications/NotificationColor";
jest.useFakeTimers();
@ -1452,4 +1456,29 @@ describe("SpaceStore", () => {
expect(client.getVisibleRooms).not.toHaveBeenCalledWith();
});
});
describe("setActiveRoomInSpace", () => {
it("should work with Home as all rooms space", async () => {
const room = mkRoom(room1);
const state = RoomNotificationStateStore.instance.getRoomState(room);
// @ts-ignore
state._color = NotificationColor.Grey;
jest.spyOn(RoomListStore.instance, "orderedLists", "get").mockReturnValue({
[DefaultTagID.Untagged]: [room],
});
// init the store
await run();
await setShowAllRooms(true);
store.setActiveRoomInSpace(MetaSpace.Home);
expect(spyDispatcher).toHaveBeenCalledWith(
expect.objectContaining({
action: "view_room",
room_id: room.roomId,
}),
);
});
});
});