imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix translation for keyboard shortcut displaynames (#7758)

Browse source
This commit is contained in:
Charlie Calendre 2022-02-10 10:11:35 +01:00 • committed by GitHub
parent 2f7b26214d
commit 8103e606c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/components/views/settings/tabs/user/KeyboardUserSettingsTab.tsx
View file

@ -35,7 +35,8 @@ const getKeyboardShortcutValue = (name: string) => {
}; };
const getKeyboardShortcutDisplayName = (name: string): string => { const getKeyboardShortcutDisplayName = (name: string): string => {
return getKeyboardShortcuts()[name]?.displayName as string; const keyboardShortcutDisplayName = getKeyboardShortcuts()[name]?.displayName as string;
return keyboardShortcutDisplayName && _t(keyboardShortcutDisplayName);
}; };
interface IKeyboardKeyProps { interface IKeyboardKeyProps {

6
test/components/views/settings/tabs/user/__snapshots__/KeyboardUserSettingsTab-test.tsx.snap
View file

@ -140,7 +140,7 @@ exports[`KeyboardUserSettingsTab renders list of keyboard shortcuts 1`] = `
<div <div
className="mx_KeyboardShortcut_shortcutRow" className="mx_KeyboardShortcut_shortcutRow"
> >
Cancel replying to a message missing translation: en|Cancel replying to a message
<KeyboardShortcut <KeyboardShortcut
name="keybind1" name="keybind1"
> >
@ -177,7 +177,7 @@ exports[`KeyboardUserSettingsTab renders list of keyboard shortcuts 1`] = `
<div <div
className="mx_KeyboardShortcut_shortcutRow" className="mx_KeyboardShortcut_shortcutRow"
> >
Toggle Bold missing translation: en|Toggle Bold
<KeyboardShortcut <KeyboardShortcut
name="keybind2" name="keybind2"
> >
@ -241,7 +241,7 @@ exports[`KeyboardUserSettingsTab renders list of keyboard shortcuts 1`] = `
<div <div
className="mx_KeyboardShortcut_shortcutRow" className="mx_KeyboardShortcut_shortcutRow"
> >
Select room from the room list missing translation: en|Select room from the room list
<KeyboardShortcut <KeyboardShortcut
name="keybind3" name="keybind3"
> >