From 80b44f0292ff36b87389c7b72a6b498de8c9b5bc Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Wed, 4 Mar 2020 12:05:47 -0700 Subject: [PATCH] Always calculate the category of a room All the update triggers for the RoomListStore go through the `setRoomCategory` function, so by returning early we're not actually calculating where a room should be in the list. --- src/stores/RoomListStore.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/stores/RoomListStore.js b/src/stores/RoomListStore.js index 561d865b66..aec307d28e 100644 --- a/src/stores/RoomListStore.js +++ b/src/stores/RoomListStore.js @@ -479,12 +479,6 @@ class RoomListStore extends Store { _setRoomCategory(room, category) { if (!room) return; // This should only happen in tests - if (!this._state.orderImportantFirst) { - // XXX bail here early to avoid https://github.com/vector-im/riot-web/issues/9216 - // this may mean that category updates are missed whilst not ordering by importance first - return; - } - const listsClone = {}; // Micro optimization: Support lazily loading the last timestamp in a room