fix stuff as per review

This commit is contained in:
Matthew Hodgson 2019-06-26 21:13:17 +01:00
parent 3d11eb430b
commit 7fc5d229d6

View file

@ -131,15 +131,15 @@ export default class IndicatorScrollbar extends React.Component {
// the harshness of the scroll behaviour. Should be a value between 0 and 1. // the harshness of the scroll behaviour. Should be a value between 0 and 1.
const yRetention = 1.0; const yRetention = 1.0;
// whenever see horizontal scrolling, assume the user is on a trackpad // whenever we see horizontal scrolling, assume the user is on a trackpad
// for at least the next 15 minutes. // for at least the next 1 minute.
const now = new Date().getTime(); const now = new Date().getTime();
if (Math.abs(e.deltaX) > 0) { if (Math.abs(e.deltaX) > 0) {
this._likelyTrackpadUser = true; this._likelyTrackpadUser = true;
this._checkAgainForTrackpad = now + (15 * 60 * 1000); // 15min this._checkAgainForTrackpad = now + (1 * 60 * 1000);
} }
else { else {
// if we haven't seen any horizontal scrolling for >15 minutes, assume // if we haven't seen any horizontal scrolling for a while, assume
// the user might have plugged in a mousewheel // the user might have plugged in a mousewheel
if (this._likelyTrackpadUser && now >= this._checkAgainForTrackpad) { if (this._likelyTrackpadUser && now >= this._checkAgainForTrackpad) {
this._likelyTrackpadUser = false; this._likelyTrackpadUser = false;
@ -164,7 +164,7 @@ export default class IndicatorScrollbar extends React.Component {
const additionalScroll = e.deltaY < 0 ? -50 : 50; const additionalScroll = e.deltaY < 0 ? -50 : 50;
// noinspection JSSuspiciousNameCombination // noinspection JSSuspiciousNameCombination
const val = Math.abs(e.deltaY) < 25 ? (e.deltaY + additionalScroll) : 0; const val = Math.abs(e.deltaY) < 25 ? (e.deltaY + additionalScroll) : e.deltaY;
this._scrollElement.scrollLeft += val * yRetention; this._scrollElement.scrollLeft += val * yRetention;
} }
} }