imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make more code conform to strict null checks (#10219

Browse source 
* Make more code conform to strict null checks

* Fix types

* Fix tests

* Fix remaining test assertions

* Iterate PR
This commit is contained in:
Michael Telatynski 2023-02-24 15:28:40 +00:00 • committed by GitHub
parent 4c79ecf141
commit 76b82b4b2b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
130 changed files with 603 additions and 603 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/utils/stringOrderField.ts
View file

@ -54,7 +54,7 @@ export function midPointsBetweenStrings(
interface IEntry {
index: number;
order: string;
order?: string;
}
export const reorderLexicographically = (
@ -82,12 +82,12 @@ export const reorderLexicographically = (
let canMoveLeft = true;
const nextBase =
newOrder[toIndex + 1]?.order !== undefined
? stringToBase(newOrder[toIndex + 1].order)
? stringToBase(newOrder[toIndex + 1].order!)
: BigInt(Number.MAX_VALUE);
// check how far left we would have to mutate to fit in that direction
for (let i = toIndex - 1, j = 1; i >= 0; i--, j++) {
if (newOrder[i]?.order !== undefined && nextBase - stringToBase(newOrder[i].order) > j) break;
if (newOrder[i]?.order !== undefined && nextBase - stringToBase(newOrder[i].order!) > j) break;
leftBoundIdx = i;
}
@ -108,12 +108,12 @@ export const reorderLexicographically = (
if (canDisplaceRight) {
const prevBase =
newOrder[toIndex - 1]?.order !== undefined
? stringToBase(newOrder[toIndex - 1]?.order)
? stringToBase(newOrder[toIndex - 1].order!)
: BigInt(Number.MIN_VALUE);
// check how far right we would have to mutate to fit in that direction
for (let i = toIndex + 1, j = 1; i < newOrder.length; i++, j++) {
if (newOrder[i]?.order === undefined || stringToBase(newOrder[i].order) - prevBase > j) break;
if (newOrder[i]?.order === undefined || stringToBase(newOrder[i].order!) - prevBase > j) break;
rightBoundIdx = i;
}