Use new eslint package- fix lint issues in ts and js

src/stores/BreadcrumbsStore.ts

@@ -162,5 +162,4 @@ export class BreadcrumbsStore extends AsyncStoreWithClient<IState> {
             await SettingsStore.setValue("breadcrumb_rooms", null, SettingLevel.ACCOUNT, roomIds);
         }
     }
-
 }

src/stores/CustomRoomTagStore.js

@@ -20,7 +20,8 @@ import { throttle } from "lodash";
 import SettingsStore from "../settings/SettingsStore";
 import {RoomListStoreTempProxy} from "./room-list/RoomListStoreTempProxy";
 
-const STANDARD_TAGS_REGEX = /^(m\.(favourite|lowpriority|server_notice)|im\.vector\.fake\.(invite|recent|direct|archived))$/;
+const STANDARD_TAGS_REGEX =
+  /^(m\.(favourite|lowpriority|server_notice)|im\.vector\.fake\.(invite|recent|direct|archived))$/;
 
 function commonPrefix(a, b) {
     const len = Math.min(a.length, b.length);

src/stores/MessagePreviewStore.ts

@@ -61,7 +61,7 @@ export class MessagePreviewStore extends AsyncStoreWithClient<IState> {
     /**
      * Gets the pre-translated preview for a given room
      * @param room The room to get the preview for.
-     * @returns The preview, or null if none present.
+     * @returns {string} The preview, or null if none present.
      */
     public getPreviewForRoom(room: Room): string {
         if (!room) return null; // invalid room, just return nothing

src/stores/ToastStore.ts

@@ -37,8 +37,8 @@ export default class ToastStore extends EventEmitter {
     private countSeen = 0;
 
     static sharedInstance() {
-        if (!window.mx_ToastStore) window.mx_ToastStore = new ToastStore();
-        return window.mx_ToastStore;
+        if (!window.mxToastStore) window.mxToastStore = new ToastStore();
+        return window.mxToastStore;
     }
 
     reset() {

src/stores/room-list/RoomListStore2.ts

@@ -180,7 +180,9 @@ export class RoomListStore2 extends AsyncStore<ActionPayload> {
             const roomId = eventPayload.event.getRoomId();
             const room = this.matrixClient.getRoom(roomId);
             const tryUpdate = async (updatedRoom: Room) => {
-                console.log(`[RoomListDebug] Live timeline event ${eventPayload.event.getId()} in ${updatedRoom.roomId}`);
+                console.log(
+                    `[RoomListDebug] Live timeline event ${eventPayload.event.getId()} in ${updatedRoom.roomId}`,
+                );
                 if (eventPayload.event.getType() === 'm.room.tombstone' && eventPayload.event.getStateKey() === '') {
                     console.log(`[RoomListDebug] Got tombstone event - regenerating room list`);
                     // TODO: We could probably be smarter about this
@@ -380,4 +382,4 @@ export default class RoomListStore {
     }
 }
 
-window.mx_RoomListStore2 = RoomListStore.instance;
+window.mxRoomListStore2 = RoomListStore.instance;

src/stores/room-list/algorithms/Algorithm.ts

@@ -27,7 +27,7 @@ import {
     ITagMap,
     ITagSortingMap,
     ListAlgorithm,
-    SortAlgorithm
+    SortAlgorithm,
 } from "./models";
 import { FILTER_CHANGED, FilterPriority, IFilterCondition } from "../filters/IFilterCondition";
 import { EffectiveMembership, splitRoomsByMembership } from "../membership";
@@ -305,7 +305,7 @@ export class Algorithm extends EventEmitter {
 
         if (!this._stickyRoom) {
             // If there's no sticky room, just do nothing useful.
-            if (!!this._cachedStickyRooms) {
+            if (this._cachedStickyRooms) {
                 // Clear the cache if we won't be needing it
                 this._cachedStickyRooms = null;
                 this.emit(LIST_UPDATED_EVENT);
@@ -518,13 +518,12 @@ export class Algorithm extends EventEmitter {
             }
         }
 
-        let tags = this.roomIdsToTags[room.roomId];
+        const tags = this.roomIdsToTags[room.roomId];
         if (!tags) {
             console.warn(`No tags known for "${room.name}" (${room.roomId})`);
             return false;
         }
 
-        let changed = false;
         for (const tag of tags) {
             const algorithm: OrderingAlgorithm = this.algorithms[tag];
             if (!algorithm) throw new Error(`No algorithm for ${tag}`);
@@ -535,7 +534,6 @@ export class Algorithm extends EventEmitter {
             // Flag that we've done something
             this.recalculateFilteredRoomsForTag(tag); // update filter to re-sort the list
             this.recalculateStickyRoom(tag); // update sticky room to make sure it appears if needed
-            changed = true;
         }
 
         return true;

src/stores/room-list/algorithms/list-ordering/ImportanceAlgorithm.ts

@@ -290,6 +290,7 @@ export class ImportanceAlgorithm extends OrderingAlgorithm {
 
             if (indices[lastCat] > indices[thisCat]) {
                 // "should never happen" disclaimer goes here
+                // eslint-disable-next-line max-len
                 console.warn(`!! Room list index corruption: ${lastCat} (i:${indices[lastCat]}) is greater than ${thisCat} (i:${indices[thisCat]}) - category indices are likely desynced from reality`);
 
                 // TODO: Regenerate index when this happens

src/stores/room-list/algorithms/list-ordering/NaturalAlgorithm.ts

@@ -25,7 +25,6 @@ import { Room } from "matrix-js-sdk/src/models/room";
  * additional behavioural changes are present.
  */
 export class NaturalAlgorithm extends OrderingAlgorithm {
-
     public constructor(tagId: TagID, initialSortingAlgorithm: SortAlgorithm) {
         super(tagId, initialSortingAlgorithm);
         console.log(`[RoomListDebug] Constructed a NaturalAlgorithm for ${tagId}`);
@@ -51,7 +50,11 @@ export class NaturalAlgorithm extends OrderingAlgorithm {
 
         // TODO: Optimize this to avoid useless operations
         // For example, we can skip updates to alphabetic (sometimes) and manually ordered tags
-        this.cachedOrderedRooms = await sortRoomsWithAlgorithm(this.cachedOrderedRooms, this.tagId, this.sortingAlgorithm);
+        this.cachedOrderedRooms = await sortRoomsWithAlgorithm(
+            this.cachedOrderedRooms,
+            this.tagId,
+            this.sortingAlgorithm,
+        );
 
         return true;
     }

src/stores/room-list/algorithms/list-ordering/index.ts

@@ -36,7 +36,11 @@ const ALGORITHM_FACTORIES: { [algorithm in ListAlgorithm]: AlgorithmFactory } =
  * @param {SortAlgorithm} initSort The initial sorting algorithm for the ordering algorithm.
  * @returns {Algorithm} The algorithm instance.
  */
-export function getListAlgorithmInstance(algorithm: ListAlgorithm, tagId: TagID, initSort: SortAlgorithm): OrderingAlgorithm {
+export function getListAlgorithmInstance(
+    algorithm: ListAlgorithm,
+    tagId: TagID,
+    initSort: SortAlgorithm,
+): OrderingAlgorithm {
     if (!ALGORITHM_FACTORIES[algorithm]) {
         throw new Error(`${algorithm} is not a known algorithm`);
     }

src/stores/room-list/algorithms/tag-sorting/AlphabeticAlgorithm.ts

@@ -17,8 +17,6 @@ limitations under the License.
 import { Room } from "matrix-js-sdk/src/models/room";
 import { TagID } from "../../models";
 import { IAlgorithm } from "./IAlgorithm";
-import { MatrixClientPeg } from "../../../../MatrixClientPeg";
-import * as Unread from "../../../../Unread";
 
 /**
  * Sorts rooms according to the browser's determination of alphabetic.

src/stores/room-list/algorithms/tag-sorting/RecentAlgorithm.ts

@@ -25,7 +25,7 @@ import * as Unread from "../../../../Unread";
  * useful to the user.
  */
 export class RecentAlgorithm implements IAlgorithm {
-    public async sortRooms(rooms: Room[], tagId: TagID): Promise<Room[]> {
+    public async sortRooms(rooms: Room[], _: TagID): Promise<Room[]> {
         // We cache the timestamp lookup to avoid iterating forever on the timeline
         // of events. This cache only survives a single sort though.
         // We wouldn't need this if `.sort()` didn't constantly try and compare all