imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Minor tweaks to UserSettings dialog (#12651)

Browse source 
* Make user settings dialog title looks like figma design

* dialog: add title to close button

* Update dialog snapshot

* Update playwright snapshot
This commit is contained in:
Florian Duros 2024-06-20 11:29:38 +02:00 • committed by GitHub
parent 7e7b55efe3
commit 6c99b91210
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 175 additions and 158 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/components/views/dialogs/BaseDialog.tsx
View file

@ -128,6 +128,7 @@ export default class BaseDialog extends React.Component<IProps> {
onClick={this.onCancelClick}
className="mx_Dialog_cancelButton"
aria-label={_t("dialog_close_label")}
title={_t("dialog_close_label")}
/>
);
}
@ -184,8 +185,8 @@ export default class BaseDialog extends React.Component<IProps> {
)}
{this.props.headerButton}
</div>
{cancelButton}
{this.props.children}
{cancelButton}
</FocusLock>
</MatrixClientContext.Provider>
);

3
src/components/views/dialogs/UserSettingsDialog.tsx
View file

@ -50,7 +50,7 @@ interface IProps {
function titleForTabID(tabId: UserTab): React.ReactNode {
const subs = {
strong: (sub: string) => <strong>{sub}</strong>,
strong: (sub: string) => <span className="mx_UserSettingsDialog_title_strong">{sub}</span>,
};
switch (tabId) {
case UserTab.General:
@ -230,6 +230,7 @@ export default function UserSettingsDialog(props: IProps): JSX.Element {
hasCancel={true}
onFinished={props.onFinished}
title={titleForTabID(activeTabId)}
titleClass="mx_UserSettingsDialog_title"
>
<div className="mx_SettingsDialog_content">
<TabbedView