Make more of the codebase conform to strict types (#10857)

test/editor/mock.ts

@@ -82,12 +82,12 @@ export function createPartCreator(completions: PillPart[] = []) {
 }
 
 export function createRenderer() {
-    const render = (c: Caret) => {
+    const render = (c?: Caret) => {
         render.caret = c;
         render.count += 1;
     };
     render.count = 0;
-    render.caret = null as unknown as Caret;
+    render.caret = null as unknown as Caret | undefined;
     return render;
 }
 

test/editor/position-test.ts

@@ -15,18 +15,7 @@ limitations under the License.
 */
 
 import EditorModel from "../../src/editor/model";
-import { createPartCreator } from "./mock";
-import { Caret } from "../../src/editor/caret";
-
-function createRenderer() {
-    const render = (c: Caret) => {
-        render.caret = c;
-        render.count += 1;
-    };
-    render.count = 0;
-    render.caret = null;
-    return render;
-}
+import { createPartCreator, createRenderer } from "./mock";
 
 describe("editor/position", function () {
     it("move first position backward in empty model", function () {

test/stores/SetupEncryptionStore-test.ts

@@ -48,8 +48,8 @@ describe("SetupEncryptionStore", () => {
         client.bootstrapCrossSigning.mockImplementation(async (opts: IBootstrapCrossSigningOpts) => {
             await opts?.authUploadDeviceSigningKeys?.(makeRequest);
         });
-        mocked(accessSecretStorage).mockImplementation(async (func: () => Promise<void>) => {
-            await func();
+        mocked(accessSecretStorage).mockImplementation(async (func?: () => Promise<void>) => {
+            await func!();
         });
 
         await setupEncryptionStore.resetConfirm();