Remove maxHeight prop

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This commit is contained in:
Šimon Brandner 2021-03-02 20:31:39 +01:00
parent 4e9d19d3b0
commit 69cdbef3d6
No known key found for this signature in database
GPG key ID: 9760693FDD98A790
2 changed files with 3 additions and 23 deletions

View file

@ -39,9 +39,6 @@ interface IProps {
// Another ongoing call to display information about // Another ongoing call to display information about
secondaryCall?: MatrixCall, secondaryCall?: MatrixCall,
// maxHeight style attribute for the video panel
maxVideoHeight?: number;
// a callback which is called when the content in the callview changes // a callback which is called when the content in the callview changes
// in a way that is likely to cause a resize. // in a way that is likely to cause a resize.
onResize?: any; onResize?: any;
@ -517,20 +514,9 @@ export default class CallView extends React.Component<IProps, IState> {
localVideoFeed = <VideoFeed type={VideoFeedType.Local} call={this.props.call} />; localVideoFeed = <VideoFeed type={VideoFeedType.Local} call={this.props.call} />;
} }
// if we're fullscreen, we don't want to set a maxHeight on the video element. contentView = <div className={containerClasses} ref={this.contentRef} onMouseMove={this.onMouseMove}>
const maxVideoHeight = getFullScreenElement() || !this.props.maxVideoHeight ? null : (
this.props.maxVideoHeight - (HEADER_HEIGHT + BOTTOM_PADDING + BOTTOM_MARGIN_TOP_BOTTOM)
);
contentView = <div className={containerClasses}
ref={this.contentRef} onMouseMove={this.onMouseMove}
// Put the max height on here too because this div is ended up 4px larger than the content
// and is causing it to scroll, and I am genuinely baffled as to why.
style={{maxHeight: maxVideoHeight}}
>
{onHoldBackground} {onHoldBackground}
<VideoFeed type={VideoFeedType.Remote} call={this.props.call} onResize={this.props.onResize} <VideoFeed type={VideoFeedType.Remote} call={this.props.call} onResize={this.props.onResize} />
maxHeight={maxVideoHeight}
/>
{localVideoFeed} {localVideoFeed}
{onHoldContent} {onHoldContent}
{callControls} {callControls}

View file

@ -29,9 +29,6 @@ interface IProps {
type: VideoFeedType, type: VideoFeedType,
// maxHeight style attribute for the video element
maxHeight?: number,
// a callback which is called when the video element is resized // a callback which is called when the video element is resized
// due to a change in video metadata // due to a change in video metadata
onResize?: (e: Event) => void, onResize?: (e: Event) => void,
@ -80,9 +77,6 @@ export default class VideoFeed extends React.Component<IProps> {
), ),
}; };
let videoStyle = {}; return <video className={classnames(videoClasses)} ref={this.vid} />;
if (this.props.maxHeight) videoStyle = { maxHeight: this.props.maxHeight };
return <video className={classnames(videoClasses)} ref={this.vid} style={videoStyle} />;
} }
} }