More posthog tracking around joining rooms and room search (#7807)

src/components/views/settings/JoinRuleSettings.tsx

@@ -271,7 +271,7 @@ const JoinRuleSettings = ({ room, promptUpgrade, aliasWarning, onError, beforeCh
                         dis.dispatch<ViewRoomPayload>({
                             action: Action.ViewRoom,
                             room_id: roomId,
-                            _trigger: undefined, // other
+                            metricsTrigger: undefined, // other
                         });
 
                         // open new settings on this tab

src/components/views/settings/tabs/room/AdvancedRoomSettingsTab.tsx

@@ -95,8 +95,8 @@ export default class AdvancedRoomSettingsTab extends React.Component<IProps, ISt
             action: Action.ViewRoom,
             room_id: this.state.oldRoomId,
             event_id: this.state.oldEventId,
-            _trigger: "WebPredecessorSettings",
-            _viaKeyboard: e.type !== "click",
+            metricsTrigger: "WebPredecessorSettings",
+            metricsViaKeyboard: e.type !== "click",
         });
         this.props.closeSettingsFn();
     };

src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx

@@ -117,7 +117,7 @@ const CommunityMigrator = ({ onFinished }) => {
                             dis.dispatch<ViewRoomPayload>({
                                 action: Action.ViewRoom,
                                 room_id: community.spaceId,
-                                _trigger: undefined, // other
+                                metricsTrigger: undefined, // other
                             });
                             onFinished();
                         } else {