Properly type Modal props to ensure useful typescript checking (#10238

* Properly type Modal props to ensure useful typescript checking * delint * Iterate * Iterate * Fix modal.close loop * Iterate * Fix tests * Add comment * Fix test
2023-02-28 10:31:48 +00:00 · 2023-02-28 10:31:48 +00:00 · 629e5cb01f
commit 629e5cb01f
parent ae5725b24c
124 changed files with 600 additions and 560 deletions
--- a/src/components/views/dialogs/RoomSettingsDialog.tsx
+++ b/src/components/views/dialogs/RoomSettingsDialog.tsx
@ -45,7 +45,7 @@ export const ROOM_ADVANCED_TAB = "ROOM_ADVANCED_TAB";

 interface IProps {
    roomId: string;
-    onFinished: (success: boolean) => void;
+    onFinished: (success?: boolean) => void;
    initialTabId?: string;
 }