imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Implement DecryptionFailureTracker for less agressive tracking

Browse source 
Instead of pinging Analytics once per failed decryption, add the failure
to a list of failures and after a grace period, add it to a FIFO for
tracking. On an interval, track a single failure from the FIFO.
This commit is contained in:
Luke Barnard 2018-06-15 13:33:07 +01:00
parent 3cadbd3974
commit 62601d657d
3 changed files with 262 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/components/structures/MatrixChat.js
View file

@ -23,6 +23,7 @@ import PropTypes from 'prop-types';
import Matrix from "matrix-js-sdk";
import Analytics from "../../Analytics";
import DecryptionFailureTracker from "../../DecryptionFailureTracker";
import MatrixClientPeg from "../../MatrixClientPeg";
import PlatformPeg from "../../PlatformPeg";
import SdkConfig from "../../SdkConfig";
@ -1308,14 +1309,17 @@ export default React.createClass({
}
});
// XXX: This will do a HTTP request for each Event.decrypted event
// if the decryption was a failure
cli.on("Event.decrypted", (e) => {
if (e.isDecryptionFailure()) {
Analytics.trackEvent('E2E', 'Decryption failure', 'ev.content.body: ' + e.getContent().body);
}
const dft = new DecryptionFailureTracker((failure) => {
// TODO: Pass reason for failure as third argument to trackEvent
Analytics.trackEvent('E2E', 'Decryption failure');
});
const stopDft = dft.start();
// When logging out, stop tracking failures and destroy state
cli.on("Session.logged_out", stopDft);
cli.on("Event.decrypted", dft.eventDecrypted);
const krh = new KeyRequestHandler(cli);
cli.on("crypto.roomKeyRequest", (req) => {
krh.handleKeyRequest(req);