Comply with noImplicitAny (#9940)

* Stash noImplicitAny work

* Stash

* Fix imports

* Iterate

* Fix tests

* Delint

* Fix tests

test/components/views/dialogs/AccessSecretStorageDialog-test.tsx

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
+import React, { ComponentProps } from "react";
 import { IPassphraseInfo } from "matrix-js-sdk/src/crypto/api";
 import { act, fireEvent, render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
@@ -29,7 +29,7 @@ const securityKey = "EsTc WKmb ivvk jLS7 Y1NH 5CcQ mP1E JJwj B3Fd pFWm t4Dp dbyu
 describe("AccessSecretStorageDialog", () => {
     let mockClient: Mocked<MatrixClient>;
 
-    const defaultProps = {
+    const defaultProps: ComponentProps<typeof AccessSecretStorageDialog> = {
         onFinished: jest.fn(),
         checkPrivateKey: jest.fn(),
         keyInfo: undefined,

test/components/views/dialogs/ExportDialog-test.tsx

@@ -16,7 +16,7 @@ limitations under the License.
 
 import React from "react";
 // eslint-disable-next-line deprecate/import
-import { mount } from "enzyme";
+import { mount, ReactWrapper } from "enzyme";
 import { mocked } from "jest-mock";
 import { act } from "react-dom/test-utils";
 import { Room } from "matrix-js-sdk/src/matrix";
@@ -60,42 +60,43 @@ describe("<ExportDialog />", () => {
 
     const getComponent = (props = {}) => mount(<ExportDialog {...defaultProps} {...props} />);
 
-    const getSizeInput = (component) => component.find('input[id="size-limit"]');
-    const getExportTypeInput = (component) => component.find('select[id="export-type"]');
-    const getAttachmentsCheckbox = (component) => component.find('input[id="include-attachments"]');
-    const getMessageCountInput = (component) => component.find('input[id="message-count"]');
-    const getExportFormatInput = (component, format) => component.find(`input[id="exportFormat-${format}"]`);
-    const getPrimaryButton = (component) => component.find('[data-testid="dialog-primary-button"]');
-    const getSecondaryButton = (component) => component.find('[data-testid="dialog-cancel-button"]');
+    const getSizeInput = (component: ReactWrapper) => component.find('input[id="size-limit"]');
+    const getExportTypeInput = (component: ReactWrapper) => component.find('select[id="export-type"]');
+    const getAttachmentsCheckbox = (component: ReactWrapper) => component.find('input[id="include-attachments"]');
+    const getMessageCountInput = (component: ReactWrapper) => component.find('input[id="message-count"]');
+    const getExportFormatInput = (component: ReactWrapper, format: ExportFormat) =>
+        component.find(`input[id="exportFormat-${format}"]`);
+    const getPrimaryButton = (component: ReactWrapper) => component.find('[data-testid="dialog-primary-button"]');
+    const getSecondaryButton = (component: ReactWrapper) => component.find('[data-testid="dialog-cancel-button"]');
 
-    const submitForm = async (component) =>
+    const submitForm = async (component: ReactWrapper) =>
         act(async () => {
             getPrimaryButton(component).simulate("click");
             component.setProps({});
         });
-    const selectExportFormat = async (component, format: ExportFormat) =>
+    const selectExportFormat = async (component: ReactWrapper, format: ExportFormat) =>
         act(async () => {
             getExportFormatInput(component, format).simulate("change");
             component.setProps({});
         });
-    const selectExportType = async (component, type: ExportType) =>
+    const selectExportType = async (component: ReactWrapper, type: ExportType) =>
         act(async () => {
             getExportTypeInput(component).simulate("change", { target: { value: type } });
             component.setProps({});
         });
-    const setMessageCount = async (component, count: number) =>
+    const setMessageCount = async (component: ReactWrapper, count: number) =>
         act(async () => {
             getMessageCountInput(component).simulate("change", { target: { value: count } });
             component.setProps({});
         });
 
-    const setSizeLimit = async (component, limit: number) =>
+    const setSizeLimit = async (component: ReactWrapper, limit: number) =>
         act(async () => {
             getSizeInput(component).simulate("change", { target: { value: limit } });
             component.setProps({});
         });
 
-    const setIncludeAttachments = async (component, checked) =>
+    const setIncludeAttachments = async (component: ReactWrapper, checked: boolean) =>
         act(async () => {
             getAttachmentsCheckbox(component).simulate("change", { target: { checked } });
             component.setProps({});

test/components/views/dialogs/ForwardDialog-test.tsx

@@ -125,8 +125,8 @@ describe("ForwardDialog", () => {
         const { container } = mountForwardDialog();
 
         // Make sendEvent require manual resolution so we can see the sending state
-        let finishSend;
-        let cancelSend;
+        let finishSend: (arg?: any) => void;
+        let cancelSend: () => void;
         mockClient.sendEvent.mockImplementation(
             <T extends {}>() =>
                 new Promise<T>((resolve, reject) => {
@@ -135,8 +135,8 @@ describe("ForwardDialog", () => {
                 }),
         );
 
-        let firstButton;
-        let secondButton;
+        let firstButton: Element;
+        let secondButton: Element;
         const update = () => {
             [firstButton, secondButton] = container.querySelectorAll(".mx_ForwardList_sendButton");
         };
@@ -253,7 +253,7 @@ describe("ForwardDialog", () => {
                 [M_ASSET.name]: { type: LocationAssetType.Pin },
                 [M_LOCATION.name]: {
                     uri: geoUri,
-                    description: undefined,
+                    description: undefined as string,
                 },
             };
             expect(mockClient.sendEvent).toHaveBeenCalledWith(
@@ -280,7 +280,7 @@ describe("ForwardDialog", () => {
                 [M_ASSET.name]: { type: LocationAssetType.Pin },
                 [M_LOCATION.name]: {
                     uri: geoUri,
-                    description: undefined,
+                    description: undefined as string,
                 },
             };
             expect(mockClient.sendEvent).toHaveBeenCalledWith(
@@ -301,7 +301,7 @@ describe("ForwardDialog", () => {
                 [M_ASSET.name]: { type: LocationAssetType.Pin },
                 [M_LOCATION.name]: {
                     uri: geoUri,
-                    description: undefined,
+                    description: undefined as string,
                 },
                 geo_uri: geoUri,
                 [M_TIMESTAMP.name]: timestamp,

test/components/views/dialogs/UserSettingsDialog-test.tsx

@@ -73,8 +73,9 @@ describe("<UserSettingsDialog />", () => {
         mockSdkConfig.get.mockReturnValue({ brand: "Test" });
     });
 
-    const getActiveTabLabel = (container) => container.querySelector(".mx_TabbedView_tabLabel_active").textContent;
-    const getActiveTabHeading = (container) => container.querySelector(".mx_SettingsTab_heading").textContent;
+    const getActiveTabLabel = (container: Element) =>
+        container.querySelector(".mx_TabbedView_tabLabel_active").textContent;
+    const getActiveTabHeading = (container: Element) => container.querySelector(".mx_SettingsTab_heading").textContent;
 
     it("should render general settings tab when no initialTabId", () => {
         const { container } = render(getComponent());