Comply with noImplicitAny (#9940)

* Stash noImplicitAny work

* Stash

* Fix imports

* Iterate

* Fix tests

* Delint

* Fix tests

src/async-components/views/dialogs/eventindex/ManageEventIndexDialog.tsx

@@ -14,7 +14,8 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
+import React, { ChangeEvent } from "react";
+import { Room } from "matrix-js-sdk/src/models/room";
 
 import { _t } from "../../../../languageHandler";
 import SdkConfig from "../../../../SdkConfig";
@@ -27,6 +28,7 @@ import Field from "../../../../components/views/elements/Field";
 import BaseDialog from "../../../../components/views/dialogs/BaseDialog";
 import DialogButtons from "../../../../components/views/elements/DialogButtons";
 import { IDialogProps } from "../../../../components/views/dialogs/IDialogProps";
+import { IIndexStats } from "../../../../indexing/BaseEventIndexManager";
 
 interface IProps extends IDialogProps {}
 
@@ -43,7 +45,7 @@ interface IState {
  * Allows the user to introspect the event index state and disable it.
  */
 export default class ManageEventIndexDialog extends React.Component<IProps, IState> {
-    public constructor(props) {
+    public constructor(props: IProps) {
         super(props);
 
         this.state = {
@@ -56,9 +58,9 @@ export default class ManageEventIndexDialog extends React.Component<IProps, ISta
         };
     }
 
-    public updateCurrentRoom = async (room): Promise<void> => {
+    public updateCurrentRoom = async (room: Room): Promise<void> => {
         const eventIndex = EventIndexPeg.get();
-        let stats;
+        let stats: IIndexStats;
 
         try {
             stats = await eventIndex.getStats();
@@ -136,8 +138,8 @@ export default class ManageEventIndexDialog extends React.Component<IProps, ISta
         Modal.createDialog(DisableEventIndexDialog, null, null, /* priority = */ false, /* static = */ true);
     };
 
-    private onCrawlerSleepTimeChange = (e): void => {
-        this.setState({ crawlerSleepTime: e.target.value });
+    private onCrawlerSleepTimeChange = (e: ChangeEvent<HTMLInputElement>): void => {
+        this.setState({ crawlerSleepTime: parseInt(e.target.value, 10) });
         SettingsStore.setValue("crawlerSleepTime", null, SettingLevel.DEVICE, e.target.value);
     };
 

src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx

@@ -20,7 +20,7 @@ import FileSaver from "file-saver";
 import { logger } from "matrix-js-sdk/src/logger";
 import { IKeyBackupInfo } from "matrix-js-sdk/src/crypto/keybackup";
 import { TrustInfo } from "matrix-js-sdk/src/crypto/backup";
-import { CrossSigningKeys } from "matrix-js-sdk/src/matrix";
+import { CrossSigningKeys, UIAFlow } from "matrix-js-sdk/src/matrix";
 import { IRecoveryKey } from "matrix-js-sdk/src/crypto/api";
 import { CryptoEvent } from "matrix-js-sdk/src/crypto";
 
@@ -206,7 +206,7 @@ export default class CreateSecretStorageDialog extends React.PureComponent<IProp
                 logger.log("uploadDeviceSigningKeys advertised no flows!");
                 return;
             }
-            const canUploadKeysWithPasswordOnly = error.data.flows.some((f) => {
+            const canUploadKeysWithPasswordOnly = error.data.flows.some((f: UIAFlow) => {
                 return f.stages.length === 1 && f.stages[0] === "m.login.password";
             });
             this.setState({

src/async-components/views/dialogs/security/ExportE2eKeysDialog.tsx

@@ -16,7 +16,7 @@ limitations under the License.
 */
 
 import FileSaver from "file-saver";
-import React from "react";
+import React, { ChangeEvent } from "react";
 import { MatrixClient } from "matrix-js-sdk/src/client";
 import { logger } from "matrix-js-sdk/src/logger";
 
@@ -163,7 +163,9 @@ export default class ExportE2eKeysDialog extends React.Component<IProps, IState>
                                 <Field
                                     label={_t("Enter passphrase")}
                                     value={this.state.passphrase1}
-                                    onChange={(e) => this.onPassphraseChange(e, "passphrase1")}
+                                    onChange={(e: ChangeEvent<HTMLInputElement>) =>
+                                        this.onPassphraseChange(e, "passphrase1")
+                                    }
                                     autoFocus={true}
                                     size={64}
                                     type="password"
@@ -174,7 +176,9 @@ export default class ExportE2eKeysDialog extends React.Component<IProps, IState>
                                 <Field
                                     label={_t("Confirm passphrase")}
                                     value={this.state.passphrase2}
-                                    onChange={(e) => this.onPassphraseChange(e, "passphrase2")}
+                                    onChange={(e: ChangeEvent<HTMLInputElement>) =>
+                                        this.onPassphraseChange(e, "passphrase2")
+                                    }
                                     size={64}
                                     type="password"
                                     disabled={disableForm}

src/async-components/views/dialogs/security/ImportE2eKeysDialog.tsx

@@ -73,9 +73,9 @@ export default class ImportE2eKeysDialog extends React.Component<IProps, IState>
     }
 
     private onFormChange = (): void => {
-        const files = this.file.current.files || [];
+        const files = this.file.current.files;
         this.setState({
-            enableSubmit: this.state.passphrase !== "" && files.length > 0,
+            enableSubmit: this.state.passphrase !== "" && !!files?.length,
         });
     };