diff --git a/src/components/views/dialogs/BugReportDialog.js b/src/components/views/dialogs/BugReportDialog.js index 4f9b592691..e00104b99c 100644 --- a/src/components/views/dialogs/BugReportDialog.js +++ b/src/components/views/dialogs/BugReportDialog.js @@ -50,6 +50,13 @@ export default class BugReportDialog extends React.Component { } _onSubmit(ev) { + if ((!this.state.text || !this.state.text.trim()) && (!this.state.issueUrl || !this.state.issueUrl.trim())) { + this.setState({ + err: _t("Please tell us what went wrong or, better, a github issue that describes the problem."), + }); + return; + } + const userText = (this.state.text.length > 0 ? this.state.text + '\n\n': '') + 'Issue: ' + (this.state.issueUrl.length > 0 ? this.state.issueUrl : 'No issue link given'); @@ -93,7 +100,7 @@ export default class BugReportDialog extends React.Component { this.setState({ issueUrl: ev.target.value }); } - _onSendLogsChange(ev) { + _onSendLogsChange(ev) { this.setState({ sendLogs: ev.target.checked }); } diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 6a25d7f00e..0972142403 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1108,6 +1108,7 @@ "Unable to find profiles for the Matrix IDs listed below - would you like to invite them anyway?": "Unable to find profiles for the Matrix IDs listed below - would you like to invite them anyway?", "Invite anyway and never warn me again": "Invite anyway and never warn me again", "Invite anyway": "Invite anyway", + "Please tell us what went wrong or, better, a github issue that describes the problem.": "Please tell us what went wrong or, better, a github issue that describes the problem.", "Preparing to send logs": "Preparing to send logs", "Logs sent": "Logs sent", "Thank you!": "Thank you!", diff --git a/test/components/structures/GroupView-test.js b/test/components/structures/GroupView-test.js index d163a1d6cb..b0768d3911 100644 --- a/test/components/structures/GroupView-test.js +++ b/test/components/structures/GroupView-test.js @@ -187,7 +187,7 @@ describe('GroupView', function() { const avatarImgElement = ReactDOM.findDOMNode(img); expect(avatarImgElement).toBeTruthy(); expect(avatarImgElement.src).toContain( - 'https://my.home.server/_matrix/media/v1/thumbnail/' + + 'https://my.home.server/_matrix/media/r0/thumbnail/' + 'someavatarurl?width=28&height=28&method=crop', ); @@ -265,7 +265,7 @@ describe('GroupView', function() { expect(longDescElement.innerHTML).toContain('