imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve randomString mock for better snapshots (#11375)

Browse source
This commit is contained in:
Michael Telatynski 2023-08-09 09:39:48 +01:00 • committed by GitHub
parent c3574c2050
commit 57a0d99dc8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
49 changed files with 133 additions and 256 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/components/views/settings/tabs/user/AppearanceUserSettingsTab-test.tsx
View file

@ -21,11 +21,6 @@ import { MatrixClient } from "matrix-js-sdk/src/matrix";
import AppearanceUserSettingsTab from "../../../../../../src/components/views/settings/tabs/user/AppearanceUserSettingsTab";
import { withClientContextRenderOptions, stubClient } from "../../../../../test-utils";
// Fake random strings to give a predictable snapshot
jest.mock("matrix-js-sdk/src/randomstring", () => ({
randomString: () => "abdefghi",
}));
describe("AppearanceUserSettingsTab", () => {
let client: MatrixClient;

5
test/components/views/settings/tabs/user/SessionManagerTab-test.tsx
View file

@ -54,11 +54,6 @@ import { getClientInformationEventType } from "../../../../../../src/utils/devic
mockPlatformPeg();
// Fake random strings to give a predictable snapshot for IDs
jest.mock("matrix-js-sdk/src/randomstring", () => ({
randomString: () => "abdefghi",
}));
describe("<SessionManagerTab />", () => {
const aliceId = "@alice:server.org";
const deviceId = "alices_device";

6
test/components/views/settings/tabs/user/SidebarUserSettingsTab-test.tsx
View file

@ -24,12 +24,6 @@ import { MetaSpace } from "../../../../../../src/stores/spaces";
import { SettingLevel } from "../../../../../../src/settings/SettingLevel";
import { flushPromises } from "../../../../../test-utils";
// used by checkbox to relate labels to inputs
// make it stable for snapshot testing
jest.mock("matrix-js-sdk/src/randomstring", () => ({
randomString: jest.fn().mockReturnValue("abcd"),
}));
describe("<SidebarUserSettingsTab />", () => {
beforeEach(() => {
jest.spyOn(PosthogTrackers, "trackInteraction").mockClear();

4
test/components/views/settings/tabs/user/__snapshots__/AppearanceUserSettingsTab-test.tsx.snap
View file

@ -303,11 +303,11 @@ exports[`AppearanceUserSettingsTab should render 1`] = `
class="mx_Checkbox mx_Checkbox_hasKind mx_Checkbox_kind_solid"
>
<input
id="checkbox_abdefghi"
id="checkbox_vY7Q4uEh9K"
type="checkbox"
/>
<label
for="checkbox_abdefghi"
for="checkbox_vY7Q4uEh9K"
>
<div
class="mx_Checkbox_background"

2
test/components/views/settings/tabs/user/__snapshots__/SessionManagerTab-test.tsx.snap
View file

@ -328,7 +328,7 @@ exports[`<SessionManagerTab /> goes to filtered list from security recommendatio
class="mx_FilteredDeviceListHeader"
>
<div
aria-describedby="mx_TooltipTarget_abdefghi"
aria-describedby="mx_TooltipTarget_vY7Q4uEh"
tabindex="0"
>
<span

20
test/components/views/settings/tabs/user/__snapshots__/SidebarUserSettingsTab-test.tsx.snap
View file

@ -49,11 +49,11 @@ exports[`<SidebarUserSettingsTab /> renders sidebar settings 1`] = `
<input
checked=""
disabled=""
id="checkbox_abcd"
id="checkbox_vY7Q4uEh9K"
type="checkbox"
/>
<label
for="checkbox_abcd"
for="checkbox_vY7Q4uEh9K"
>
<div
class="mx_Checkbox_background"
@ -82,11 +82,11 @@ exports[`<SidebarUserSettingsTab /> renders sidebar settings 1`] = `
>
<input
data-testid="mx_SidebarUserSettingsTab_homeAllRoomsCheckbox"
id="checkbox_abcd"
id="checkbox_38QgU2Pomx"
type="checkbox"
/>
<label
for="checkbox_abcd"
for="checkbox_38QgU2Pomx"
>
<div
class="mx_Checkbox_background"
@ -113,11 +113,11 @@ exports[`<SidebarUserSettingsTab /> renders sidebar settings 1`] = `
class="mx_Checkbox mx_SidebarUserSettingsTab_checkbox mx_Checkbox_hasKind mx_Checkbox_kind_solid"
>
<input
id="checkbox_abcd"
id="checkbox_wKpa6hpi3Y"
type="checkbox"
/>
<label
for="checkbox_abcd"
for="checkbox_wKpa6hpi3Y"
>
<div
class="mx_Checkbox_background"
@ -145,11 +145,11 @@ exports[`<SidebarUserSettingsTab /> renders sidebar settings 1`] = `
class="mx_Checkbox mx_SidebarUserSettingsTab_checkbox mx_Checkbox_hasKind mx_Checkbox_kind_solid"
>
<input
id="checkbox_abcd"
id="checkbox_EetmBG4yVC"
type="checkbox"
/>
<label
for="checkbox_abcd"
for="checkbox_EetmBG4yVC"
>
<div
class="mx_Checkbox_background"
@ -177,11 +177,11 @@ exports[`<SidebarUserSettingsTab /> renders sidebar settings 1`] = `
class="mx_Checkbox mx_SidebarUserSettingsTab_checkbox mx_Checkbox_hasKind mx_Checkbox_kind_solid"
>
<input
id="checkbox_abcd"
id="checkbox_eEefiPqpMR"
type="checkbox"
/>
<label
for="checkbox_abcd"
for="checkbox_eEefiPqpMR"
>
<div
class="mx_Checkbox_background"