imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't intercept TAB on the app outside of the composer, fix tabIndex > 0

Browse source 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2019-10-10 14:13:29 +01:00
parent 7160922b77
commit 5643743167
7 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/components/structures/ContextualMenu.js
View file

@ -176,7 +176,6 @@ export default class ContextualMenu extends React.Component {
const menuClasses = classNames({
'mx_ContextualMenu': true,
'mx_HiddenFocusable': true, // hide browser outline
'mx_ContextualMenu_left': !hasChevron && position.left,
'mx_ContextualMenu_right': !hasChevron && position.right,
'mx_ContextualMenu_top': !hasChevron && position.top,

4
src/components/structures/GroupView.js
View file

@ -1223,7 +1223,7 @@ export default createReactClass({
blurToCancel={false}
initialValue={this.state.profileForm.name}
onValueChanged={this._onNameChange}
tabIndex="1"
tabIndex="0"
dir="auto" />;
shortDescNode = <EditableText ref="descriptionEditor"
@ -1233,7 +1233,7 @@ export default createReactClass({
blurToCancel={false}
initialValue={this.state.profileForm.short_description}
onValueChanged={this._onShortDescChange}
tabIndex="2"
tabIndex="0"
dir="auto" />;
} else {
const onGroupHeaderItemClick = this.state.isUserMember ? this._onEditClick : null;

2
src/components/structures/LoggedInView.js
View file

@ -408,7 +408,7 @@ const LoggedInView = createReactClass({
return;
}
if (!isClickShortcut && !canElementReceiveInput(ev.target)) {
if (!isClickShortcut && ev.key !== Key.TAB && !canElementReceiveInput(ev.target)) {
// synchronous dispatch so we focus before key generates input
dis.dispatch({action: 'focus_composer'}, true);
ev.stopPropagation();