Use semantic heading in user settings Sidebar & Voip (#10782)

* split SettingsSection out of SettingsTab, replace usage * correct copyright * use semantic headings in GeneralRoomSettingsTab * use SettingsTab and SettingsSubsection in room settings * fix VoipRoomSettingsTab * use SettingsSection components in space settings * settingssubsection text component * use semantic headings in HelpUserSetttings tab * use ExternalLink components for external links * test * strict * lint * semantic heading in labs settings * semantic headings in keyboard settings tab * semantic heading in preferencesusersettingstab * tidying * use new settings components in eventindexpanel * findByTestId * prettier * semantic headings and style refresh for crypto settings * e2e panel * semantic headings and cleanup in Sidebar user settings * semantic heading in voice user settings * sonarcloud bug and test
2023-05-19 12:03:39 +12:00 · 2023-05-19 12:03:39 +12:00 · 55336bf932
commit 55336bf932
parent d9a61c093c
12 changed files with 446 additions and 189 deletions
--- a/test/components/views/settings/tabs/user/SidebarUserSettingsTab-test.tsx
+++ b/test/components/views/settings/tabs/user/SidebarUserSettingsTab-test.tsx
@ -0,0 +1,88 @@
+/*
+Copyright 2023 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import React from "react";
+import { fireEvent, render, screen } from "@testing-library/react";
+
+import SidebarUserSettingsTab from "../../../../../../src/components/views/settings/tabs/user/SidebarUserSettingsTab";
+import PosthogTrackers from "../../../../../../src/PosthogTrackers";
+import SettingsStore from "../../../../../../src/settings/SettingsStore";
+import { MetaSpace } from "../../../../../../src/stores/spaces";
+import { SettingLevel } from "../../../../../../src/settings/SettingLevel";
+import { flushPromises } from "../../../../../test-utils";
+
+// used by checkbox to relate labels to inputs
+// make it stable for snapshot testing
+jest.mock("matrix-js-sdk/src/randomstring", () => ({
+    randomString: jest.fn().mockReturnValue("abcd"),
+}));
+
+describe("<SidebarUserSettingsTab />", () => {
+    beforeEach(() => {
+        jest.spyOn(PosthogTrackers, "trackInteraction").mockClear();
+        jest.spyOn(SettingsStore, "getValue").mockRestore();
+        jest.spyOn(SettingsStore, "setValue").mockReset();
+    });
+
+    it("renders sidebar settings", () => {
+        const { container } = render(<SidebarUserSettingsTab />);
+        expect(container).toMatchSnapshot();
+    });
+
+    it("toggles all rooms in home setting", async () => {
+        jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName) => {
+            if (settingName === "Spaces.enabledMetaSpaces") {
+                return {
+                    [MetaSpace.Home]: true,
+                    [MetaSpace.Favourites]: true,
+                    [MetaSpace.People]: true,
+                    [MetaSpace.Orphans]: true,
+                };
+            }
+            return false;
+        });
+        render(<SidebarUserSettingsTab />);
+
+        fireEvent.click(screen.getByTestId("mx_SidebarUserSettingsTab_homeAllRoomsCheckbox"));
+
+        await flushPromises();
+        expect(SettingsStore.setValue).toHaveBeenCalledWith("Spaces.allRoomsInHome", null, SettingLevel.ACCOUNT, true);
+
+        expect(PosthogTrackers.trackInteraction).toHaveBeenCalledWith(
+            "WebSettingsSidebarTabSpacesCheckbox",
+            // synthetic event from checkbox
+            expect.objectContaining({ type: "change" }),
+            1,
+        );
+    });
+
+    it("disables all rooms in home setting when home space is disabled", () => {
+        jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName) => {
+            if (settingName === "Spaces.enabledMetaSpaces") {
+                return {
+                    [MetaSpace.Home]: false,
+                    [MetaSpace.Favourites]: true,
+                    [MetaSpace.People]: true,
+                    [MetaSpace.Orphans]: true,
+                };
+            }
+            return false;
+        });
+        render(<SidebarUserSettingsTab />);
+
+        expect(screen.getByTestId("mx_SidebarUserSettingsTab_homeAllRoomsCheckbox")).toBeDisabled();
+    });
+});