imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Playwright: Fix thread root skipped tests (#12067)

Browse source 
* Fix thread root skipped tests

* Add comment about collapsed content in `redactions.spec.ts`

---------

Co-authored-by: David Baker <dbkr@users.noreply.github.com>
This commit is contained in:
Florian Duros 2023-12-19 10:59:05 +01:00 • committed by GitHub
parent 4c2efc3637
commit 537b4a1971
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
playwright/e2e/read-receipts/index.ts
View file

@ -370,6 +370,15 @@ class Helpers {
await this.app.viewRoomByName(typeof room === "string" ? room : room.name); await this.app.viewRoomByName(typeof room === "string" ? room : room.name);
} }
/**
* Expand the message with the supplied index in the timeline.
* @param index
*/
async openCollapsedMessage(index: number) {
const button = this.page.locator(".mx_GenericEventListSummary_toggle");
await button.nth(index).click();
}
/** /**
* Click the thread with the supplied content in the thread root to open it in * Click the thread with the supplied content in the thread root to open it in
* the Threads panel. * the Threads panel.

12
playwright/e2e/read-receipts/redactions.spec.ts
View file

@ -849,8 +849,7 @@ test.describe("Read receipts", () => {
// Then the room is still read // Then the room is still read
await util.assertStillRead(room2); await util.assertStillRead(room2);
}); });
// TODO: Can't open a thread on a redacted thread root test("Redacting a thread root still allows us to read the thread", async ({
test.skip("Redacting a thread root still allows us to read the thread", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -874,12 +873,13 @@ test.describe("Read receipts", () => {
// And I can open the thread and read it // And I can open the thread and read it
await util.goTo(room2); await util.goTo(room2);
await util.assertUnread(room2, 2); await util.assertUnread(room2, 2);
await util.openThread("Root"); // The redacted message gets collapsed into, "foo was invited, joined and removed a message"
await util.openCollapsedMessage(1);
await util.openThread("Message deleted");
await util.assertRead(room2); await util.assertRead(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// TODO: Can't open a thread on a redacted thread root test("Sending a threaded message onto a redacted thread root leaves the room unread", async ({
test.skip("Sending a threaded message onto a redacted thread root leaves the room unread", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -905,7 +905,7 @@ test.describe("Read receipts", () => {
// Then the room and thread are unread // Then the room and thread are unread
await util.assertUnread(room2, 1); await util.assertUnread(room2, 1);
await util.goTo(room2); await util.goTo(room2);
await util.assertUnreadThread("Root"); await util.assertUnreadThread("Message deleted");
}); });
test("Reacting to a redacted thread root leaves the room read", async ({ test("Reacting to a redacted thread root leaves the room read", async ({
roomAlpha: room1, roomAlpha: room1,