imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Conform more of the codebase to strictNullChecks (#10738)

Browse source
This commit is contained in:
Michael Telatynski 2023-05-09 18:24:40 +01:00 • committed by GitHub
parent 5e8488c283
commit 52017f62e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 105 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/linkify-matrix.ts
View file

@ -191,12 +191,12 @@ export const options: Opts = {
return {};
},
formatHref: function (href: string, type: Type | string): string | null {
formatHref: function (href: string, type: Type | string): string {
switch (type) {
case Type.RoomAlias:
case Type.UserId:
default: {
return tryTransformEntityToPermalink(href);
return tryTransformEntityToPermalink(href) ?? "";
}
}
},
@ -209,7 +209,7 @@ export const options: Opts = {
className: "linkified",
target: function (href: string, type: Type | string): string | null {
target: function (href: string, type: Type | string): string {
if (type === Type.URL) {
try {
const transformed = tryTransformPermalinkToLocalHref(href);
@ -217,7 +217,7 @@ export const options: Opts = {
transformed !== href || // if it could be converted to handle locally for matrix symbols e.g. @user:server.tdl and matrix.to
decodeURIComponent(href).match(ELEMENT_URL_PATTERN) // for https links to Element domains
) {
return null;
return "";
} else {
return "_blank";
}
@ -225,7 +225,7 @@ export const options: Opts = {
// malformed URI
}
}
return null;
return "";
},
};