imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Delay URL preview saving until the save button is pressed

Browse source 
Signed-off-by: Travis Ralston <travpc@gmail.com>
This commit is contained in:
Travis Ralston 2017-11-04 16:32:13 -06:00
parent 358298e4ee
commit 4f1ad974fc
3 changed files with 37 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/components/views/room_settings/UrlPreviewSettings.js
View file

@ -29,8 +29,7 @@ module.exports = React.createClass({
},
saveSettings: function() {
// TODO: {Travis} move toggle logic here instead of being 'live'
return [];
return [this.refs.urlPreviewsRoom.save(), this.refs.urlPreviewsSelf.save()];
},
render: function() {
@ -48,15 +47,16 @@ module.exports = React.createClass({
);
}
// TODO: {Travis} This needs to be an explicit true/false for "room" only.
let previewsForRoom = null;
if (SettingsStore.canSetValue("urlPreviewsEnabled", roomId, "room")) {
previewsForRoom = (
<label>
<SettingsFlag name="urlPreviewsEnabled"
level={SettingLevel.ROOM}
roomId={this.props.room.roomId}
isExplicit={true} />
level={SettingLevel.ROOM}
roomId={this.props.room.roomId}
isExplicit={true}
manualSave={true}
ref="urlPreviewsRoom" />
</label>
);
} else {
@ -69,8 +69,10 @@ module.exports = React.createClass({
let previewsForRoomAccount = (
<SettingsFlag name="urlPreviewsEnabled"
level={SettingLevel.ROOM_ACCOUNT}
roomId={this.props.room.roomId}
level={SettingLevel.ROOM_ACCOUNT}
roomId={this.props.room.roomId}
manualSave={true}
ref="urlPreviewsSelf"
/>
);