imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix jumping when unfilling the top while scrolling down

Browse source
This commit is contained in:
Bruno Windels 2019-03-22 15:23:21 +01:00
parent ab49bc4fcf
commit 4bfdbe3094
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/components/structures/ScrollPanel.js
View file

@ -642,11 +642,17 @@ module.exports = React.createClass({
// the currently filled piece of the timeline // the currently filled piece of the timeline
if (trackedNode) { if (trackedNode) {
const oldTop = trackedNode.offsetTop; const oldTop = trackedNode.offsetTop;
// changing the height might change the scrollTop
// if the new height is smaller than the scrollTop.
// We calculate the diff that needs to be applied
// ourselves, so be sure to measure the
// scrollTop before changing the height.
const preexistingScrollTop = sn.scrollTop;
itemlist.style.height = `${newHeight}px`; itemlist.style.height = `${newHeight}px`;
const newTop = trackedNode.offsetTop; const newTop = trackedNode.offsetTop;
const topDiff = newTop - oldTop; const topDiff = newTop - oldTop;
sn.scrollTop = sn.scrollTop + topDiff; sn.scrollTop = preexistingScrollTop + topDiff;
debuglog("updateHeight to", newHeight, topDiff); debuglog("updateHeight to", {newHeight, topDiff, preexistingScrollTop});
} }
} }
}, },