Fix soft crash around inviting invalid MXIDs in start DM on first message flow (#9281)

* Fix soft crash around inviting invalid MXIDs * Make ts --strict happier * Prevent suggesting invalid MXIDs * Add tests * Fix coverage * Fix coverage * Make tsc --strict happier * Fix test * Add tests
2022-09-16 09:03:17 +01:00 · 2022-09-16 09:03:17 +01:00 · 4a23630e06
commit 4a23630e06
parent 4fec436883
6 changed files with 194 additions and 57 deletions
--- a/test/components/views/dialogs/InviteDialog-test.tsx
+++ b/test/components/views/dialogs/InviteDialog-test.tsx
@ -0,0 +1,113 @@
+/*
+Copyright 2022 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import React from "react";
+import { render, screen } from "@testing-library/react";
+
+import InviteDialog from "../../../../src/components/views/dialogs/InviteDialog";
+import { KIND_INVITE } from "../../../../src/components/views/dialogs/InviteDialogTypes";
+import { getMockClientWithEventEmitter, mkStubRoom } from "../../../test-utils";
+import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
+import DMRoomMap from "../../../../src/utils/DMRoomMap";
+import SdkConfig from "../../../../src/SdkConfig";
+import { ValidatedServerConfig } from "../../../../src/utils/ValidatedServerConfig";
+import { IConfigOptions } from "../../../../src/IConfigOptions";
+
+describe("InviteDialog", () => {
+    const roomId = "!111111111111111111:example.org";
+    const aliceId = "@alice:example.org";
+    const mockClient = getMockClientWithEventEmitter({
+        getUserId: jest.fn().mockReturnValue(aliceId),
+        isGuest: jest.fn().mockReturnValue(false),
+        getVisibleRooms: jest.fn().mockReturnValue([]),
+        getRoom: jest.fn(),
+        getRooms: jest.fn(),
+        getAccountData: jest.fn(),
+        getPushActionsForEvent: jest.fn(),
+        mxcUrlToHttp: jest.fn().mockReturnValue(''),
+        isRoomEncrypted: jest.fn().mockReturnValue(false),
+        getProfileInfo: jest.fn().mockRejectedValue({ errcode: "" }),
+        getIdentityServerUrl: jest.fn(),
+        searchUserDirectory: jest.fn().mockResolvedValue({}),
+    });
+
+    beforeEach(() => {
+        SdkConfig.put({ validated_server_config: {} as ValidatedServerConfig } as IConfigOptions);
+        DMRoomMap.makeShared();
+        jest.clearAllMocks();
+        mockClient.getUserId.mockReturnValue("@bob:example.org");
+
+        const room = mkStubRoom(roomId, "Room", mockClient);
+        mockClient.getRooms.mockReturnValue([room]);
+        mockClient.getRoom.mockReturnValue(room);
+    });
+
+    afterAll(() => {
+        jest.spyOn(MatrixClientPeg, 'get').mockRestore();
+    });
+
+    it("should label with space name", () => {
+        mockClient.getRoom(roomId).isSpaceRoom = jest.fn().mockReturnValue(true);
+        mockClient.getRoom(roomId).name = "Space";
+        render((
+            <InviteDialog
+                kind={KIND_INVITE}
+                roomId={roomId}
+                onFinished={jest.fn()}
+            />
+        ));
+
+        expect(screen.queryByText("Invite to Space")).toBeTruthy();
+    });
+
+    it("should label with room name", () => {
+        render((
+            <InviteDialog
+                kind={KIND_INVITE}
+                roomId={roomId}
+                onFinished={jest.fn()}
+            />
+        ));
+
+        expect(screen.queryByText("Invite to Room")).toBeTruthy();
+    });
+
+    it("should suggest valid MXIDs even if unknown", () => {
+        render((
+            <InviteDialog
+                kind={KIND_INVITE}
+                roomId={roomId}
+                onFinished={jest.fn()}
+                initialText="@localpart:server.tld"
+            />
+        ));
+
+        expect(screen.queryByText("@localpart:server.tld")).toBeFalsy();
+    });
+
+    it("should not suggest invalid MXIDs", () => {
+        render((
+            <InviteDialog
+                kind={KIND_INVITE}
+                roomId={roomId}
+                onFinished={jest.fn()}
+                initialText="@localpart:server:tld"
+            />
+        ));
+
+        expect(screen.queryByText("@localpart:server:tld")).toBeFalsy();
+    });
+});