imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor tests

Browse source 
So that there's one top level `describe('TextForEvent')`, followed by a nested
`describe('textForPinnedEvent')`, containting all the `it()`s.

Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
This commit is contained in:
Paulo Pinto 2021-08-10 16:06:33 +01:00
parent 94d3dd6bbc
commit 45fd3d83b0
2 changed files with 77 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

136
test/TextForEvent-test.ts
View file

@ -23,88 +23,64 @@ function mockPinnedEvent(
}); });
} }
describe("TextForPinnedEvent - newly pinned message(s)", () => { describe('TextForEvent', () => {
SettingsStore.setValue("feature_pinning", null, SettingLevel.DEVICE, true); describe("TextForPinnedEvent", () => {
SettingsStore.setValue("feature_pinning", null, SettingLevel.DEVICE, true);
it("mentions message when a single message was pinned, with no previously pinned messages", () => { it("mentions message when a single message was pinned, with no previously pinned messages", () => {
const event = mockPinnedEvent(['message-1']); const event = mockPinnedEvent(['message-1']);
expect(textForEvent(event)).toBe("@foo:example.com pinned a message to this room. See all pinned messages."); expect(textForEvent(event)).toBe(
}); "@foo:example.com pinned a message to this room. See all pinned messages.",
);
it("mentions message when a single message was pinned, with multiple previously pinned messages", () => { const component = renderer.create(textForEvent(event, true));
const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2']); expect(component.toJSON()).toMatchSnapshot();
expect(textForEvent(event)).toBe("@foo:example.com pinned a message to this room. See all pinned messages."); });
});
it("shows generic text when multiple messages were pinned", () => { it("mentions message when a single message was pinned, with multiple previously pinned messages", () => {
const event = mockPinnedEvent(['message-1', 'message-2', 'message-3'], ['message-1']); const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2']);
expect(textForEvent(event)).toBe("@foo:example.com changed the pinned messages for the room."); expect(textForEvent(event)).toBe(
}); "@foo:example.com pinned a message to this room. See all pinned messages.",
}); );
describe("TextForPinnedEvent - newly pinned message(s) (JSX)", () => { const component = renderer.create(textForEvent(event, true));
SettingsStore.setValue("feature_pinning", null, SettingLevel.DEVICE, true); expect(component.toJSON()).toMatchSnapshot();
});
it("mentions message when a single message was pinned, with no previously pinned messages", () => {
const event = mockPinnedEvent(['message-1']); it("shows generic text when multiple messages were pinned", () => {
const component = renderer.create(textForEvent(event, true)); const event = mockPinnedEvent(['message-1', 'message-2', 'message-3'], ['message-1']);
expect(component.toJSON()).toMatchSnapshot(); expect(textForEvent(event)).toBe("@foo:example.com changed the pinned messages for the room.");
});
const component = renderer.create(textForEvent(event, true));
it("mentions message when a single message was pinned, with multiple previously pinned messages", () => { expect(component.toJSON()).toMatchSnapshot();
const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2']); });
const component = renderer.create(textForEvent(event, true));
expect(component.toJSON()).toMatchSnapshot(); it("mentions message when a single message was unpinned, with a single message previously pinned", () => {
}); const event = mockPinnedEvent([], ['message-1']);
expect(textForEvent(event)).toBe(
it("shows generic text when multiple messages were pinned", () => { "@foo:example.com unpinned a message from this room. See all pinned messages.",
const event = mockPinnedEvent(['message-1', 'message-2', 'message-3'], ['message-1']); );
const component = renderer.create(textForEvent(event, true));
expect(component.toJSON()).toMatchSnapshot(); const component = renderer.create(textForEvent(event, true));
}); expect(component.toJSON()).toMatchSnapshot();
}); });
describe("TextForPinnedEvent - newly unpinned message(s)", () => { it("mentions message when a single message was unpinned, with multiple previously pinned messages", () => {
SettingsStore.setValue("feature_pinning", null, SettingLevel.DEVICE, true); const event = mockPinnedEvent(['message-2'], ['message-1', 'message-2']);
expect(textForEvent(event)).toBe(
it("mentions message when a single message was unpinned, with a single message previously pinned", () => { "@foo:example.com unpinned a message from this room. See all pinned messages.",
const event = mockPinnedEvent([], ['message-1']); );
expect(textForEvent(event)).toBe(
"@foo:example.com unpinned a message from this room. See all pinned messages.", const component = renderer.create(textForEvent(event, true));
); expect(component.toJSON()).toMatchSnapshot();
}); });
it("mentions message when a single message was unpinned, with multiple previously pinned messages", () => { it("shows generic text when multiple messages were unpinned", () => {
const event = mockPinnedEvent(['message-2'], ['message-1', 'message-2']); const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2', 'message-3']);
expect(textForEvent(event)).toBe( expect(textForEvent(event)).toBe("@foo:example.com changed the pinned messages for the room.");
"@foo:example.com unpinned a message from this room. See all pinned messages.",
); const component = renderer.create(textForEvent(event, true));
}); expect(component.toJSON()).toMatchSnapshot();
});
it("shows generic text when multiple messages were unpinned", () => {
const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2', 'message-3']);
expect(textForEvent(event)).toBe("@foo:example.com changed the pinned messages for the room.");
});
});
describe("TextForPinnedEvent - newly unpinned message(s) (JSX)", () => {
SettingsStore.setValue("feature_pinning", null, SettingLevel.DEVICE, true);
it("mentions message when a single message was unpinned, with a single message previously pinned", () => {
const event = mockPinnedEvent([], ['message-1']);
const component = renderer.create(textForEvent(event, true));
expect(component.toJSON()).toMatchSnapshot();
});
it("mentions message when a single message was unpinned, with multiple previously pinned messages", () => {
const event = mockPinnedEvent(['message-2'], ['message-1', 'message-2']);
const component = renderer.create(textForEvent(event, true));
expect(component.toJSON()).toMatchSnapshot();
});
it("shows generic text when multiple messages were unpinned", () => {
const event = mockPinnedEvent(['message-3'], ['message-1', 'message-2', 'message-3']);
const component = renderer.create(textForEvent(event, true));
expect(component.toJSON()).toMatchSnapshot();
}); });
}); });

42
test/__snapshots__/TextForEvent-test.ts.snap
View file

@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP // Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`TextForPinnedEvent - newly pinned message(s) (JSX) mentions message when a single message was pinned, with multiple previously pinned messages 1`] = ` exports[`TextForEvent TextForPinnedEvent mentions message when a single message was pinned, with multiple previously pinned messages 1`] = `
<span> <span>
<span> <span>
@foo:example.com pinned @foo:example.com pinned
@ -20,7 +20,7 @@ exports[`TextForPinnedEvent - newly pinned message(s) (JSX) mentions message whe
</span> </span>
`; `;
exports[`TextForPinnedEvent - newly pinned message(s) (JSX) mentions message when a single message was pinned, with no previously pinned messages 1`] = ` exports[`TextForEvent TextForPinnedEvent mentions message when a single message was pinned, with no previously pinned messages 1`] = `
<span> <span>
<span> <span>
@foo:example.com pinned @foo:example.com pinned
@ -40,23 +40,7 @@ exports[`TextForPinnedEvent - newly pinned message(s) (JSX) mentions message whe
</span> </span>
`; `;
exports[`TextForPinnedEvent - newly pinned message(s) (JSX) shows generic text when multiple messages were pinned 1`] = ` exports[`TextForEvent TextForPinnedEvent mentions message when a single message was unpinned, with a single message previously pinned 1`] = `
<span>
<span>
@foo:example.com changed the
<a
onClick={[Function]}
>
pinned messages
</a>
for the room.
</span>
</span>
`;
exports[`TextForPinnedEvent - newly unpinned message(s) (JSX) mentions message when a single message was unpinned, with a single message previously pinned 1`] = `
<span> <span>
<span> <span>
@foo:example.com unpinned @foo:example.com unpinned
@ -76,7 +60,7 @@ exports[`TextForPinnedEvent - newly unpinned message(s) (JSX) mentions message w
</span> </span>
`; `;
exports[`TextForPinnedEvent - newly unpinned message(s) (JSX) mentions message when a single message was unpinned, with multiple previously pinned messages 1`] = ` exports[`TextForEvent TextForPinnedEvent mentions message when a single message was unpinned, with multiple previously pinned messages 1`] = `
<span> <span>
<span> <span>
@foo:example.com unpinned @foo:example.com unpinned
@ -96,7 +80,23 @@ exports[`TextForPinnedEvent - newly unpinned message(s) (JSX) mentions message w
</span> </span>
`; `;
exports[`TextForPinnedEvent - newly unpinned message(s) (JSX) shows generic text when multiple messages were unpinned 1`] = ` exports[`TextForEvent TextForPinnedEvent shows generic text when multiple messages were pinned 1`] = `
<span>
<span>
@foo:example.com changed the
<a
onClick={[Function]}
>
pinned messages
</a>
for the room.
</span>
</span>
`;
exports[`TextForEvent TextForPinnedEvent shows generic text when multiple messages were unpinned 1`] = `
<span> <span>
<span> <span>
@foo:example.com changed the @foo:example.com changed the