imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sonar happier (#9114)

Browse source 
* Make sonar happier

* Rename method
This commit is contained in:
Michael Telatynski 2022-07-29 12:01:15 +01:00 • committed by GitHub
parent 6a8dd23d29
commit 45f6c32eb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/components/views/dialogs/InviteDialog.tsx
View file

@ -29,7 +29,7 @@ import { makeRoomPermalink, makeUserPermalink } from "../../../utils/permalinks/
import DMRoomMap from "../../../utils/DMRoomMap";
import SdkConfig from "../../../SdkConfig";
import * as Email from "../../../email";
import { getDefaultIdentityServerUrl, useDefaultIdentityServer } from "../../../utils/IdentityServerUtils";
import { getDefaultIdentityServerUrl, setToDefaultIdentityServer } from "../../../utils/IdentityServerUtils";
import { buildActivityScores, buildMemberScores, compareMembers } from "../../../utils/SortMembers";
import { abbreviateUrl } from "../../../utils/UrlUtils";
import IdentityAuthClient from "../../../IdentityAuthClient";
@ -815,7 +815,7 @@ export default class InviteDialog extends React.PureComponent<IInviteDialogProps
// Update the IS in account data. Actually using it may trigger terms.
// eslint-disable-next-line react-hooks/rules-of-hooks
useDefaultIdentityServer();
setToDefaultIdentityServer();
this.setState({ canUseIdentityServer: true, tryingIdentityServer: false });
};

23
src/components/views/dialogs/devtools/VerificationExplorer.tsx
View file

@ -16,12 +16,7 @@ limitations under the License.
import React, { useContext, useEffect, useState } from "react";
import {
PHASE_CANCELLED,
PHASE_DONE,
PHASE_READY,
PHASE_REQUESTED,
PHASE_STARTED,
PHASE_UNSENT,
Phase,
VerificationRequest,
VerificationRequestEvent,
} from "matrix-js-sdk/src/crypto/verification/request/VerificationRequest";
@ -32,13 +27,13 @@ import { _t, _td } from "../../../../languageHandler";
import MatrixClientContext from "../../../../contexts/MatrixClientContext";
import BaseTool, { DevtoolsContext, IDevtoolsProps } from "./BaseTool";
const PHASE_MAP = {
[PHASE_UNSENT]: _td("Unsent"),
[PHASE_REQUESTED]: _td("Requested"),
[PHASE_READY]: _td("Ready"),
[PHASE_DONE]: _td("Done"),
[PHASE_STARTED]: _td("Started"),
[PHASE_CANCELLED]: _td("Cancelled"),
const PHASE_MAP: Record<Phase, string> = {
[Phase.Unsent]: _td("Unsent"),
[Phase.Requested]: _td("Requested"),
[Phase.Ready]: _td("Ready"),
[Phase.Done]: _td("Done"),
[Phase.Started]: _td("Started"),
[Phase.Cancelled]: _td("Cancelled"),
};
const VerificationRequestExplorer: React.FC<{
@ -68,7 +63,7 @@ const VerificationRequestExplorer: React.FC<{
<dt>{ _t("Transaction") }</dt>
<dd>{ txnId }</dd>
<dt>{ _t("Phase") }</dt>
<dd>{ PHASE_MAP[request.phase] || request.phase }</dd> // TODO
<dd>{ PHASE_MAP[request.phase] ? _t(PHASE_MAP[request.phase]) : request.phase }</dd>
<dt>{ _t("Timeout") }</dt>
<dd>{ Math.floor(timeout / 1000) }</dd>
<dt>{ _t("Methods") }</dt>

2
src/components/views/elements/UseCaseSelection.tsx
View file

@ -32,9 +32,9 @@ const TIMEOUT = 1500;
export function UseCaseSelection({ onFinished }: Props) {
const [selection, setSelected] = useState<UseCase | null>(null);
// Call onFinished 1.5s after `selection` becomes truthy, to give time for the animation to run
useEffect(() => {
if (selection) {
setSelected(selection);
let handler: number | null = setTimeout(() => {
handler = null;
onFinished(selection);