Conform more code to strict null checking (#10167)

* Conform more code to strict null checking

* Delint

* Iterate PR based on feedback

src/settings/controllers/IncompatibleController.ts

@@ -36,7 +36,7 @@ export default class IncompatibleController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         if (this.incompatibleSetting) {
             return this.forcedValue;

src/settings/controllers/NotificationControllers.ts

@@ -53,7 +53,7 @@ export class NotificationsEnabledController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         if (!getNotifier().isPossible()) return false;
 

src/settings/controllers/OrderedMultiController.ts

@@ -35,7 +35,7 @@ export class OrderedMultiController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         for (const controller of this.controllers) {
             const override = controller.getValueOverride(level, roomId, calculatedValue, calculatedAtLevel);

src/settings/controllers/ReducedMotionController.ts

@@ -27,7 +27,7 @@ export default class ReducedMotionController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         if (this.prefersReducedMotion()) {
             return false;

src/settings/controllers/SettingController.ts

@@ -41,7 +41,7 @@ export default abstract class SettingController {
         level: SettingLevel,
         roomId: string | null,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         return null; // no override
     }

src/settings/controllers/ThemeController.ts

@@ -26,7 +26,7 @@ export default class ThemeController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         if (!calculatedValue) return null; // Don't override null themes
 

src/settings/controllers/UIFeatureController.ts

@@ -34,7 +34,7 @@ export default class UIFeatureController extends SettingController {
         level: SettingLevel,
         roomId: string,
         calculatedValue: any,
-        calculatedAtLevel: SettingLevel,
+        calculatedAtLevel: SettingLevel | null,
     ): any {
         if (this.settingDisabled) {
             // per the docs: we force a disabled state when the feature isn't active