imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't assume false means "use state"

Browse source 
Signed-off-by: Travis Ralston <travpc@gmail.com>
This commit is contained in:
Travis Ralston 2017-11-04 19:52:42 -07:00
parent ef45d82ec6
commit 45140cab69
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/components/structures/UserSettings.js
View file

@ -763,9 +763,9 @@ module.exports = React.createClass({
return ( return (
<div className="mx_UserSettings_toggle" key={setting.id}> <div className="mx_UserSettings_toggle" key={setting.id}>
<SettingsFlag name={setting.id} <SettingsFlag name={setting.id}
label={setting.label} label={setting.label}
level={SettingLevel.DEVICE} level={SettingLevel.DEVICE}
onChange={setting.fn} /> onChange={setting.fn} />
</div> </div>
); );
}, },

4
src/components/views/elements/SettingsFlag.js
View file

@ -54,12 +54,12 @@ module.exports = React.createClass({
if (this.props.onChange) this.props.onChange(newState); if (this.props.onChange) this.props.onChange(newState);
}, },
save: function(val = null) { save: function(val = undefined) {
return SettingsStore.setValue( return SettingsStore.setValue(
this.props.name, this.props.name,
this.props.roomId, this.props.roomId,
this.props.level, this.props.level,
val ? val : this.state.value val !== undefined ? val : this.state.value
); );
}, },