imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Unit test ExportDialog (#7619)

Browse source 
* add test ids to dialog buttons

Signed-off-by: Kerry Archibald <kerrya@element.io>

* unit test ExportDialog

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove extra snapshot

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix bad snapshots

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove wrappers from snapshot

Signed-off-by: Kerry Archibald <kerrya@element.io>
This commit is contained in:
Kerry 2022-01-27 09:55:08 +01:00 • committed by GitHub
parent 50f8c61fa8
commit 3eca71bc84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 3175 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/components/views/dialogs/ExportDialog.tsx
View file

@ -138,7 +138,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
},
invalid: () => {
const min = 1;
const max = 10 ** 8;
const max = 2000;
return _t("Enter a number between %(min)s and %(max)s", {
min,
max,
@ -239,6 +239,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
if (exportType === ExportType.LastNMessages) {
messageCount = (
<Field
id="message-count"
element="input"
type="number"
value={numberOfMessages.toString()}
@ -335,6 +336,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
</span>
<Field
id="export-type"
element="select"
value={exportType}
onChange={(e) => {
@ -350,6 +352,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
</span>
<Field
id="size-limit"
type="number"
autoComplete="off"
onValidate={onValidateSize}
@ -361,6 +364,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
/>
<StyledCheckbox
id="include-attachments"
checked={includeAttachments}
onChange={(e) =>
setAttachments(
@ -372,7 +376,7 @@ const ExportDialog: React.FC<IProps> = ({ room, onFinished }) => {
</StyledCheckbox>
</div>
{ isExporting ? (
<div className="mx_ExportDialog_progress">
<div data-test-id='export-progress' className="mx_ExportDialog_progress">
<Spinner w={24} h={24} />
<p>
{ exportProgressText }

2
src/components/views/elements/DialogButtons.tsx
View file

@ -83,6 +83,7 @@ export default class DialogButtons extends React.Component<IProps> {
cancelButton = <button
// important: the default type is 'submit' and this button comes before the
// primary in the DOM so will get form submissions unless we make it not a submit.
data-test-id="dialog-cancel-button"
type="button"
onClick={this.onCancelClick}
className={this.props.cancelButtonClass}
@ -103,6 +104,7 @@ export default class DialogButtons extends React.Component<IProps> {
{ cancelButton }
{ this.props.children }
<button type={this.props.primaryIsSubmit ? 'submit' : 'button'}
data-test-id="dialog-primary-button"
className={primaryButtonClassName}
onClick={this.props.onPrimaryButtonClick}
autoFocus={this.props.focus}

3
src/components/views/elements/StyledCheckbox.tsx
View file

@ -28,6 +28,7 @@ export enum CheckboxStyle {
interface IProps extends React.InputHTMLAttributes<HTMLInputElement> {
inputRef?: React.RefObject<HTMLInputElement>;
kind?: CheckboxStyle;
id?: string;
}
interface IState {
@ -44,7 +45,7 @@ export default class StyledCheckbox extends React.PureComponent<IProps, IState>
constructor(props: IProps) {
super(props);
// 56^10 so unlikely chance of collision.
this.id = "checkbox_" + randomString(10);
this.id = this.props.id || "checkbox_" + randomString(10);
}
public render() {