imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Get selection range only if necessary

Browse source 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This commit is contained in:
Šimon Brandner 2021-06-20 08:47:21 +02:00
parent a772460f63
commit 3e97847e7d
No known key found for this signature in database
GPG key ID: 9760693FDD98A790
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/components/views/rooms/BasicMessageComposer.tsx
View file

@ -441,10 +441,6 @@ export default class BasicMessageEditor extends React.Component<IProps, IState>
}; };
private onKeyDown = (event: React.KeyboardEvent) => { private onKeyDown = (event: React.KeyboardEvent) => {
const selectionRange = getRangeForSelection(this.editorRef.current, this.props.model, document.getSelection());
// trim the range as we want it to exclude leading/trailing spaces
selectionRange.trim();
const model = this.props.model; const model = this.props.model;
let handled = false; let handled = false;
@ -452,6 +448,15 @@ export default class BasicMessageEditor extends React.Component<IProps, IState>
// This surrounds the selected text with a character. This is // This surrounds the selected text with a character. This is
// intentionally left out of the keybinding manager as the keybinds // intentionally left out of the keybinding manager as the keybinds
// here shouldn't be changeable // here shouldn't be changeable
const selectionRange = getRangeForSelection(
this.editorRef.current,
this.props.model,
document.getSelection(),
);
// trim the range as we want it to exclude leading/trailing spaces
selectionRange.trim();
if (SURROUND_WITH_CHARACTERS.includes(event.key)) { if (SURROUND_WITH_CHARACTERS.includes(event.key)) {
this.historyManager.ensureLastChangesPushed(this.props.model); this.historyManager.ensureLastChangesPushed(this.props.model);
this.modifiedFlag = true; this.modifiedFlag = true;