Remove Piwik support (#8835)

* Remove all mentions of Piwik

* Kill off all consumer of the old Piwik Analytics module

* Simplify ModalManager interface

* i18n

* Attempt to fix old e2e tests

* Remove unused component

* Iterate PR

src/components/views/elements/ActionButton.tsx

@@ -1,105 +0,0 @@
-/*
-Copyright 2017 Vector Creations Ltd
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-import React from 'react';
-
-import AccessibleButton from './AccessibleButton';
-import dis from '../../../dispatcher/dispatcher';
-import Analytics from '../../../Analytics';
-import Tooltip from './Tooltip';
-
-interface IProps {
-    size?: string;
-    tooltip?: boolean;
-    action: string;
-    mouseOverAction?: string;
-    label: string;
-    iconPath?: string;
-    className?: string;
-    children?: JSX.Element;
-}
-
-interface IState {
-    showTooltip: boolean;
-}
-
-export default class ActionButton extends React.Component<IProps, IState> {
-    static defaultProps: Partial<IProps> = {
-        size: "25",
-        tooltip: false,
-    };
-
-    constructor(props: IProps) {
-        super(props);
-
-        this.state = {
-            showTooltip: false,
-        };
-    }
-
-    private onClick = (ev: React.MouseEvent): void => {
-        ev.stopPropagation();
-        Analytics.trackEvent('Action Button', 'click', this.props.action);
-        dis.dispatch({ action: this.props.action });
-    };
-
-    private onMouseEnter = (): void => {
-        this.showTooltip();
-        if (this.props.mouseOverAction) {
-            dis.dispatch({ action: this.props.mouseOverAction });
-        }
-    };
-
-    private showTooltip = (): void => {
-        if (this.props.tooltip) this.setState({ showTooltip: true });
-    };
-
-    private hideTooltip = (): void => {
-        this.setState({ showTooltip: false });
-    };
-
-    render() {
-        let tooltip;
-        if (this.state.showTooltip) {
-            tooltip = <Tooltip className="mx_RoleButton_tooltip" label={this.props.label} />;
-        }
-
-        const icon = this.props.iconPath ?
-            (<img src={this.props.iconPath} width={this.props.size} height={this.props.size} />) :
-            undefined;
-
-        const classNames = ["mx_RoleButton"];
-        if (this.props.className) {
-            classNames.push(this.props.className);
-        }
-
-        return (
-            <AccessibleButton
-                className={classNames.join(" ")}
-                onClick={this.onClick}
-                onMouseEnter={this.onMouseEnter}
-                onMouseLeave={this.hideTooltip}
-                onFocus={this.showTooltip}
-                onBlur={this.hideTooltip}
-                aria-label={this.props.label}
-            >
-                { icon }
-                { tooltip }
-                { this.props.children }
-            </AccessibleButton>
-        );
-    }
-}

src/components/views/elements/ErrorBoundary.tsx

@@ -68,7 +68,7 @@ export default class ErrorBoundary extends React.PureComponent<{}, IState> {
     };
 
     private onBugReport = (): void => {
-        Modal.createTrackedDialog('Bug Report Dialog', '', BugReportDialog, {
+        Modal.createDialog(BugReportDialog, {
             label: 'react-soft-crash',
             error: this.state.error,
         });

src/components/views/elements/MiniAvatarUploader.tsx

@@ -18,7 +18,6 @@ import classNames from 'classnames';
 import { EventType } from 'matrix-js-sdk/src/@types/event';
 import React, { useContext, useRef, useState, MouseEvent } from 'react';
 
-import Analytics from "../../../Analytics";
 import MatrixClientContext from "../../../contexts/MatrixClientContext";
 import RoomContext from "../../../contexts/RoomContext";
 import { useTimeout } from "../../../hooks/useTimeout";
@@ -74,7 +73,6 @@ const MiniAvatarUploader: React.FC<IProps> = ({
             onChange={async (ev) => {
                 if (!ev.target.files?.length) return;
                 setBusy(true);
-                Analytics.trackEvent("mini_avatar", "upload");
                 const file = ev.target.files[0];
                 const uri = await cli.uploadContent(file);
                 await setAvatarUrl(uri);

src/components/views/elements/PollCreateDialog.tsx

@@ -172,25 +172,20 @@ export default class PollCreateDialog extends ScrollableBaseModal<IProps, IState
             () => this.props.onFinished(true),
         ).catch(e => {
             console.error("Failed to post poll:", e);
-            Modal.createTrackedDialog(
-                'Failed to post poll',
-                '',
-                QuestionDialog,
-                {
-                    title: _t("Failed to post poll"),
-                    description: _t(
-                        "Sorry, the poll you tried to create was not posted."),
-                    button: _t('Try again'),
-                    cancelButton: _t('Cancel'),
-                    onFinished: (tryAgain: boolean) => {
-                        if (!tryAgain) {
-                            this.cancel();
-                        } else {
-                            this.setState({ busy: false, canSubmit: true });
-                        }
-                    },
+            Modal.createDialog(QuestionDialog, {
+                title: _t("Failed to post poll"),
+                description: _t(
+                    "Sorry, the poll you tried to create was not posted."),
+                button: _t('Try again'),
+                cancelButton: _t('Cancel'),
+                onFinished: (tryAgain: boolean) => {
+                    if (!tryAgain) {
+                        this.cancel();
+                    } else {
+                        this.setState({ busy: false, canSubmit: true });
+                    }
                 },
-            );
+            });
         });
     }
 

src/components/views/elements/ServerPicker.tsx

@@ -37,12 +37,12 @@ const showPickerDialog = (
     serverConfig: ValidatedServerConfig,
     onFinished: (config: ValidatedServerConfig) => void,
 ) => {
-    Modal.createTrackedDialog("Server Picker", "", ServerPickerDialog, { title, serverConfig, onFinished });
+    Modal.createDialog(ServerPickerDialog, { title, serverConfig, onFinished });
 };
 
 const onHelpClick = () => {
     const brand = SdkConfig.get().brand;
-    Modal.createTrackedDialog('Custom Server Dialog', '', InfoDialog, {
+    Modal.createDialog(InfoDialog, {
         title: _t("Server Options"),
         description: _t("You can use the custom server options to sign into other Matrix servers by specifying " +
             "a different homeserver URL. This allows you to use %(brand)s with an existing Matrix account on " +