imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always render disabled settings as disabled (#7014)

Browse source 
This is to prevent user confusion about whether or not a setting exists, or even what its value is. By rendering it with `disabled=true` the user is at least aware that the setting is set to a specific value, though we could (and should) do better in the future to communicate *why* a setting is disabled.
This commit is contained in:
Travis Ralston 2021-10-22 11:30:14 -06:00 • committed by GitHub
parent a1a19c7433
commit 39e98b9d7f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx
View file

@ -288,14 +288,10 @@ export default class PreferencesUserSettingsTab extends React.Component<IProps,
private renderGroup( private renderGroup(
settingIds: string[], settingIds: string[],
level = SettingLevel.ACCOUNT, level = SettingLevel.ACCOUNT,
includeDisabled = false,
): React.ReactNodeArray { ): React.ReactNodeArray {
if (!includeDisabled) {
settingIds = settingIds.filter(SettingsStore.isEnabled);
}
return settingIds.map(i => { return settingIds.map(i => {
return <SettingsFlag key={i} name={i} level={level} />; const disabled = !SettingsStore.isEnabled(i);
return <SettingsFlag key={i} name={i} level={level} disabled={disabled} />;
}); });
} }
@ -343,7 +339,7 @@ export default class PreferencesUserSettingsTab extends React.Component<IProps,
<div className="mx_SettingsTab_section"> <div className="mx_SettingsTab_section">
<span className="mx_SettingsTab_subheading">{ _t("Spaces") }</span> <span className="mx_SettingsTab_subheading">{ _t("Spaces") }</span>
{ this.renderGroup(PreferencesUserSettingsTab.SPACES_SETTINGS, SettingLevel.ACCOUNT, true) } { this.renderGroup(PreferencesUserSettingsTab.SPACES_SETTINGS, SettingLevel.ACCOUNT) }
</div> </div>
<div className="mx_SettingsTab_section"> <div className="mx_SettingsTab_section">