Merge pull request #3401 from matrix-org/jryans/bound-3pids-text

Stregthen bound 3PID warning dialog

src/components/views/settings/SetIdServer.js

@@ -260,17 +260,24 @@ export default class SetIdServer extends React.Component {
 
         const boundThreepids = threepids.filter(tp => tp.bound);
         let message;
+        let danger = false;
         if (boundThreepids.length) {
-            message = _t(
+            message = <div>
-                "You are currently sharing email addresses or phone numbers on the identity " +
+                <p>{_t(
-                "server <idserver />. You will need to reconnect to <idserver2 /> to stop " +
+                    "You are still <b>sharing your personal data</b> on the identity " +
-                "sharing them.", {},
+                    "server <idserver />.", {},
                     {
                         idserver: sub => <b>{abbreviateUrl(this.state.currentClientIdServer)}</b>,
-                    // XXX: https://github.com/vector-im/riot-web/issues/9086
+                        b: sub => <b>{sub}</b>,
-                    idserver2: sub => <b>{abbreviateUrl(this.state.currentClientIdServer)}</b>,
                     },
-            );
+                )}</p>
+                <p>{_t(
+                    "We recommend that you remove your email addresses and phone numbers " +
+                    "from the identity server before disconnecting.",
+                )}</p>
+            </div>;
+            danger = true;
+            button = _t("Disconnect anyway");
         } else {
             message = unboundMessage;
         }
@@ -280,6 +287,8 @@ export default class SetIdServer extends React.Component {
             title,
             description: message,
             button,
+            cancelButton: _t("Go back"),
+            danger,
         });
         return finished;
     }

src/i18n/strings/en_EN.json

@@ -563,7 +563,10 @@
     "Disconnect identity server": "Disconnect identity server",
     "Disconnect from the identity server <idserver />?": "Disconnect from the identity server <idserver />?",
     "Disconnect": "Disconnect",
-    "You are currently sharing email addresses or phone numbers on the identity server <idserver />. You will need to reconnect to <idserver2 /> to stop sharing them.": "You are currently sharing email addresses or phone numbers on the identity server <idserver />. You will need to reconnect to <idserver2 /> to stop sharing them.",
+    "You are still <b>sharing your personal data</b> on the identity server <idserver />.": "You are still <b>sharing your personal data</b> on the identity server <idserver />.",
+    "We recommend that you remove your email addresses and phone numbers from the identity server before disconnecting.": "We recommend that you remove your email addresses and phone numbers from the identity server before disconnecting.",
+    "Disconnect anyway": "Disconnect anyway",
+    "Go back": "Go back",
     "Identity Server (%(server)s)": "Identity Server (%(server)s)",
     "You are currently using <server></server> to discover and be discoverable by existing contacts you know. You can change your identity server below.": "You are currently using <server></server> to discover and be discoverable by existing contacts you know. You can change your identity server below.",
     "If you don't want to use <server /> to discover and be discoverable by existing contacts you know, enter another identity server below.": "If you don't want to use <server /> to discover and be discoverable by existing contacts you know, enter another identity server below.",
@@ -1287,7 +1290,6 @@
     "If you run into any bugs or have feedback you'd like to share, please let us know on GitHub.": "If you run into any bugs or have feedback you'd like to share, please let us know on GitHub.",
     "To help avoid duplicate issues, please <existingIssuesLink>view existing issues</existingIssuesLink> first (and add a +1) or <newIssueLink>create a new issue</newIssueLink> if you can't find it.": "To help avoid duplicate issues, please <existingIssuesLink>view existing issues</existingIssuesLink> first (and add a +1) or <newIssueLink>create a new issue</newIssueLink> if you can't find it.",
     "Report bugs & give feedback": "Report bugs & give feedback",
-    "Go back": "Go back",
     "Room Settings - %(roomName)s": "Room Settings - %(roomName)s",
     "Failed to upgrade room": "Failed to upgrade room",
     "The room upgrade could not be completed": "The room upgrade could not be completed",