From 30ac95052398d171edcb27e3c2258015f3c2c780 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Fri, 28 Apr 2023 08:13:04 +0000 Subject: [PATCH] Emulate TabbedView's actual min and max widths on user settings tabs (#10737) Signed-off-by: Suguru Hirahara --- cypress/e2e/settings/general-user-settings-tab.spec.ts | 4 ++++ .../e2e/settings/preferences-user-settings-tab.spec.ts | 10 +++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/cypress/e2e/settings/general-user-settings-tab.spec.ts b/cypress/e2e/settings/general-user-settings-tab.spec.ts index b818ec229d..2bdfb1b77d 100644 --- a/cypress/e2e/settings/general-user-settings-tab.spec.ts +++ b/cypress/e2e/settings/general-user-settings-tab.spec.ts @@ -45,6 +45,10 @@ describe("General user settings tab", () => { cy.get(".mx_SettingsTab.mx_GeneralUserSettingsTab").percySnapshotElement("User settings tab - General", { percyCSS, + // Emulate TabbedView's actual min and max widths + // 580: '.mx_UserSettingsDialog .mx_TabbedView' min-width + // 796: 1036 (mx_TabbedView_tabsOnLeft actual width) - 240 (mx_TabbedView_tabPanel margin-right) + widths: [580, 796], }); cy.get(".mx_SettingsTab.mx_GeneralUserSettingsTab").within(() => { diff --git a/cypress/e2e/settings/preferences-user-settings-tab.spec.ts b/cypress/e2e/settings/preferences-user-settings-tab.spec.ts index 29fb668de1..ad16f0a1c5 100644 --- a/cypress/e2e/settings/preferences-user-settings-tab.spec.ts +++ b/cypress/e2e/settings/preferences-user-settings-tab.spec.ts @@ -40,6 +40,14 @@ describe("Preferences user settings tab", () => { cy.findByTestId("preferences").should("have.text", "Preferences").should("be.visible"); }); - cy.get(".mx_SettingsTab.mx_PreferencesUserSettingsTab").percySnapshotElement("User settings tab - Preferences"); + cy.get(".mx_SettingsTab.mx_PreferencesUserSettingsTab").percySnapshotElement( + "User settings tab - Preferences", + { + // Emulate TabbedView's actual min and max widths + // 580: '.mx_UserSettingsDialog .mx_TabbedView' min-width + // 796: 1036 (mx_TabbedView_tabsOnLeft actual width) - 240 (mx_TabbedView_tabPanel margin-right) + widths: [580, 796], + }, + ); }); });