imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Switch to linkify-react for element Linkification as it handles React subtrees without exploding (#10060

Browse source 
* Switch to linkify-react instead of our faulty implementation

Fixes a series of soft crashes where errors include "The node to be removed is not a child of this node."

* Improve types

* Fix types

* Update snapshots

* Add test

* Fix test
This commit is contained in:
Michael Telatynski 2023-02-03 08:59:21 +00:00 • committed by GitHub
parent 089557005a
commit 2bde31dcff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 101 additions and 193 deletions
Download patch file Download diff file Expand all files Collapse all files

32
test/components/structures/__snapshots__/RoomView-test.tsx.snap
View file

@ -62,11 +62,9 @@ exports[`RoomView for a local room in state CREATING should match the snapshot 1
<div
tabindex="0"
>
<div>
<span
dir="auto"
/>
</div>
<span
dir="auto"
/>
</div>
</div>
</div>
@ -161,11 +159,9 @@ exports[`RoomView for a local room in state ERROR should match the snapshot 1`]
<div
tabindex="0"
>
<div>
<span
dir="auto"
/>
</div>
<span
dir="auto"
/>
</div>
</div>
</div>
@ -356,11 +352,9 @@ exports[`RoomView for a local room in state NEW should match the snapshot 1`] =
<div
tabindex="0"
>
<div>
<span
dir="auto"
/>
</div>
<span
dir="auto"
/>
</div>
</div>
</div>
@ -623,11 +617,9 @@ exports[`RoomView for a local room in state NEW that is encrypted should match t
<div
tabindex="0"
>
<div>
<span
dir="auto"
/>
</div>
<span
dir="auto"
/>
</div>
</div>
</div>

82
test/components/views/elements/Linkify-test.tsx
View file

@ -1,82 +0,0 @@
/*
Copyright 2021 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { fireEvent, render } from "@testing-library/react";
import React, { useState } from "react";
import { Linkify } from "../../../../src/components/views/elements/Linkify";
describe("Linkify", () => {
it("linkifies the context", () => {
const { container } = render(<Linkify>https://perdu.com</Linkify>);
expect(container.innerHTML).toBe(
'<div><a href="https://perdu.com" class="linkified" target="_blank" rel="noreferrer noopener">' +
"https://perdu.com" +
"</a></div>",
);
});
it("correctly linkifies a room alias", () => {
const { container } = render(<Linkify>#element-web:matrix.org</Linkify>);
expect(container.innerHTML).toBe(
"<div>" +
'<a href="https://matrix.to/#/#element-web:matrix.org" class="linkified" rel="noreferrer noopener">' +
"#element-web:matrix.org" +
"</a></div>",
);
});
it("changes the root tag name", () => {
const TAG_NAME = "p";
const { container } = render(<Linkify as={TAG_NAME}>Hello world!</Linkify>);
expect(container.querySelectorAll("p")).toHaveLength(1);
});
it("relinkifies on update", () => {
function DummyTest() {
const [n, setN] = useState(0);
function onClick() {
setN(n + 1);
}
// upon clicking the element, change the content, and expect
// linkify to update
return (
<div onClick={onClick}>
<Linkify>{n % 2 === 0 ? "https://perdu.com" : "https://matrix.org"}</Linkify>
</div>
);
}
const { container } = render(<DummyTest />);
expect(container.innerHTML).toBe(
"<div><div>" +
'<a href="https://perdu.com" class="linkified" target="_blank" rel="noreferrer noopener">' +
"https://perdu.com" +
"</a></div></div>",
);
fireEvent.click(container.querySelector("div"));
expect(container.innerHTML).toBe(
"<div><div>" +
'<a href="https://matrix.org" class="linkified" target="_blank" rel="noreferrer noopener">' +
"https://matrix.org" +
"</a></div></div>",
);
});
});