Use semantic list elements for menu lists and tab lists (#10902)
* Use semantic list elements for pop up menu lists * Use semantic list elements for tab lists * Fix tests * Update snapshot
This commit is contained in:
parent
8b7eb8bb1d
commit
296ed2273e
9 changed files with 92 additions and 82 deletions
|
@ -121,6 +121,7 @@ export default class TabbedView<T extends string> extends React.Component<IProps
|
|||
role="tab"
|
||||
aria-selected={isActive}
|
||||
aria-controls={id}
|
||||
element="li"
|
||||
>
|
||||
{tabIcon}
|
||||
<span className="mx_TabbedView_tabLabel_text" id={`${id}_label`}>
|
||||
|
@ -166,14 +167,14 @@ export default class TabbedView<T extends string> extends React.Component<IProps
|
|||
handleUpDown={this.props.tabLocation == TabLocation.LEFT}
|
||||
>
|
||||
{({ onKeyDownHandler }) => (
|
||||
<div
|
||||
<ul
|
||||
className="mx_TabbedView_tabLabels"
|
||||
role="tablist"
|
||||
aria-orientation={this.props.tabLocation == TabLocation.LEFT ? "vertical" : "horizontal"}
|
||||
onKeyDown={onKeyDownHandler}
|
||||
>
|
||||
{labels}
|
||||
</div>
|
||||
</ul>
|
||||
)}
|
||||
</RovingTabIndexProvider>
|
||||
{panel}
|
||||
|
|
|
@ -126,6 +126,7 @@ export const IconizedContextMenuOption: React.FC<IOptionProps> = ({
|
|||
}) => {
|
||||
return (
|
||||
<MenuItem
|
||||
element="li"
|
||||
{...props}
|
||||
className={classNames(className, {
|
||||
mx_IconizedContextMenu_item: true,
|
||||
|
@ -171,7 +172,9 @@ const IconizedContextMenu: React.FC<React.PropsWithChildren<IProps>> = ({ classN
|
|||
|
||||
return (
|
||||
<ContextMenu chevronFace={ChevronFace.None} {...props}>
|
||||
<div className={classes}>{children}</div>
|
||||
<ul role="none" className={classes}>
|
||||
{children}
|
||||
</ul>
|
||||
</ContextMenu>
|
||||
);
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue