Refine the colors of some more components (#12343)

* Refine the colors of some more components

This is a reintroduction of https://github.com/matrix-org/matrix-react-sdk/pull/12255, and should be the last part of the Compound color refinement work (https://github.com/element-hq/element-web/issues/26992). I've updated the following components to reflect design decisions (https://www.figma.com/file/pqhlirZFEwEp5XpudSbiia/Theming-Web-templates?type=design&node-id=80-60219&mode=design&t=mjqwylUie1vRwzOV-0) that will help them fit in better with the new design system:

- Message bubbles
- Pills
- Sent indicators
- Jump to bottom/unread buttons
- Composer placeholder
- Notification badges
- Room sublists
- Verification shields
- Date separators
- Tooltips

Closes https://github.com/element-hq/element-web/issues/22122

* Update some screenshots

res/css/_common.pcss

@@ -646,7 +646,7 @@ legend {
 
 .mx_Dialog button.warning:not(.mx_Dialog_nonDialogButton):not([class|="maplibregl"]),
 .mx_Dialog input[type="submit"].warning {
-    border: solid 1px var(--cpd-color-border-critical-primary);
+    border: solid 1px var(--cpd-color-border-critical-subtle);
     color: var(--cpd-color-text-critical-primary);
 }
 

res/css/views/elements/_Pill.pcss

@@ -26,7 +26,7 @@ limitations under the License.
     overflow: hidden;
     cursor: pointer;
 
-    color: $accent-fg-color !important; /* To override .markdown-body */
+    color: var(--cpd-color-text-on-solid-primary) !important; /* To override .markdown-body */
     background-color: $pill-bg-color !important; /* To override .markdown-body */
 
     > * {
@@ -35,7 +35,7 @@ limitations under the License.
 
     &.mx_UserPill_me,
     &.mx_AtRoomPill {
-        background-color: $alert !important; /* To override .markdown-body */
+        background-color: var(--cpd-color-bg-critical-primary) !important; /* To override .markdown-body */
     }
 
     &:hover {
@@ -43,12 +43,14 @@ limitations under the License.
     }
 
     &.mx_UserPill_me:hover {
-        background-color: #ff6b75 !important; /* To override .markdown-body | same on both themes */
+        background-color: var(
+            --cpd-color-bg-critical-hovered
+        ) !important; /* To override .markdown-body | same on both themes */
     }
 
     /* We don't want to indicate clickability */
     &.mx_AtRoomPill:hover {
-        background-color: $alert !important; /* To override .markdown-body */
+        background-color: var(--cpd-color-bg-critical-primary) !important; /* To override .markdown-body */
         cursor: unset;
     }
 

res/css/views/elements/_Tooltip.pcss

@@ -71,8 +71,8 @@ limitations under the License.
     max-width: 300px;
     word-break: break-word;
 
-    background-color: #21262c; /* Same on both themes */
+    background-color: var(--cpd-color-alpha-gray-1400);
-    color: $accent-fg-color;
+    color: var(--cpd-color-text-on-solid-primary);
     border: 0;
     text-align: center;
 

res/css/views/messages/_DateSeparator.pcss

@@ -39,5 +39,5 @@ limitations under the License.
     mask-size: contain;
     mask-repeat: no-repeat;
     mask-image: url("$(res)/img/feather-customised/chevron-down.svg");
-    background-color: $tertiary-content;
+    background-color: var(--cpd-color-icon-secondary);
 }

res/css/views/messages/_TimelineSeparator.pcss

@@ -20,12 +20,12 @@ limitations under the License.
     display: flex;
     align-items: center;
     font: var(--cpd-font-body-md-regular);
-    color: $roomtopic-color;
+    color: var(--cpd-color-text-secondary);
 }
 
 .mx_TimelineSeparator > hr {
     flex: 1 1 0;
     height: 0;
     border: none;
-    border-bottom: 1px solid $menu-selected-color;
+    border-bottom: 1px solid var(--cpd-color-gray-400);
 }

res/css/views/rooms/_BasicMessageComposer.pcss

@@ -20,7 +20,7 @@ limitations under the License.
 
     .mx_BasicMessageComposer_inputEmpty > :first-child::before {
         content: var(--placeholder);
-        opacity: 0.333;
+        color: var(--cpd-color-text-secondary);
         width: 0;
         height: 0;
         overflow: visible;

res/css/views/rooms/_E2EIcon.pcss

@@ -37,15 +37,6 @@ limitations under the License.
     }
 }
 
-/* white infill for the transparency */
-.mx_E2EIcon::before {
-    background-color: #ffffff;
-    mask-image: url("$(res)/img/e2e/normal.svg");
-    mask-repeat: no-repeat;
-    mask-position: center;
-    mask-size: 80%;
-}
-
 /* transparent-looking border surrounding the shield for when overlain over avatars */
 .mx_E2EIcon_bordered {
     mask-image: url("$(res)/img/e2e/normal.svg");
@@ -59,6 +50,7 @@ limitations under the License.
     /* shrink the infill of the badge */
     &::before {
         mask-size: 60%;
+        background: var(--cpd-color-bg-canvas-default);
     }
 }
 
@@ -69,7 +61,7 @@ limitations under the License.
 
 .mx_E2EIcon_normal::after {
     mask-image: url("$(res)/img/e2e/normal.svg");
-    background-color: $header-panel-text-primary-color;
+    background-color: var(--cpd-color-icon-tertiary);
 }
 
 .mx_E2EIcon_verified::after {

res/css/views/rooms/_EventTile.pcss

@@ -53,7 +53,7 @@ $left-gutter: 64px;
         height: 16px;
 
         &::before {
-            background-color: $tertiary-content;
+            background-color: var(--cpd-color-icon-tertiary);
             mask-repeat: no-repeat;
             mask-position: center;
             mask-size: 16px;
@@ -858,12 +858,12 @@ $left-gutter: 64px;
 
     &.mx_EventTile_e2eIcon_normal::after {
         mask-image: url("$(res)/img/e2e/normal.svg"); /* regular shield */
-        background-color: $header-panel-text-primary-color; /* grey */
+        background-color: var(--cpd-color-icon-tertiary); /* grey */
     }
 
     &.mx_EventTile_e2eIcon_decryption_failure::after {
         mask-image: url("$(res)/img/e2e/decryption-failure.svg"); /* key in a circle */
-        background-color: $secondary-content;
+        background-color: var(--cpd-color-icon-tertiary);
     }
 }
 

res/css/views/rooms/_JumpToBottomButton.pcss

@@ -39,13 +39,12 @@ limitations under the License.
     /* with text-align in parent */
     display: inline-block;
     padding: 0 4px;
-    color: $accent-fg-color;
+    color: var(--cpd-color-text-on-solid-primary);
-    background-color: $muted-fg-color;
+    background-color: var(--cpd-color-icon-secondary);
 }
 
 .mx_JumpToBottomButton_highlight .mx_JumpToBottomButton_badge {
-    color: $secondary-accent-color;
+    background-color: var(--cpd-color-icon-critical-primary);
-    background-color: $alert;
 }
 
 .mx_JumpToBottomButton_scrollDown {
@@ -55,7 +54,7 @@ limitations under the License.
     border-radius: 19px;
     box-sizing: border-box;
     background: $background;
-    border: 1.3px solid $muted-fg-color;
+    border: 1.3px solid var(--cpd-color-icon-tertiary);
     cursor: pointer;
 }
 
@@ -68,5 +67,5 @@ limitations under the License.
     mask-size: 20px;
     mask-position: center 6px;
     transform: rotate(180deg);
-    background: $muted-fg-color;
+    background: var(--cpd-color-icon-tertiary);
 }

res/css/views/rooms/_LegacyRoomHeader.pcss

@@ -185,10 +185,10 @@ limitations under the License.
     }
 
     &:hover {
-        background: $accent-300;
+        background: var(--cpd-color-bg-subtle-primary);
 
         &::before {
-            background-color: $accent;
+            background-color: var(--cpd-color-icon-primary);
         }
     }
 }
@@ -213,8 +213,8 @@ limitations under the License.
     margin: 4px;
 
     &.mx_Indicator_highlight {
-        background: $alert;
+        background: var(--cpd-color-icon-critical-primary);
-        box-shadow: $alert;
+        box-shadow: var(--cpd-color-icon-critical-primary);
     }
 
     &.mx_Indicator_notification {
@@ -223,8 +223,8 @@ limitations under the License.
     }
 
     &.mx_Indicator_activity {
-        background: $primary-content;
+        background: var(--cpd-color-icon-primary);
-        box-shadow: $primary-content;
+        box-shadow: var(--cpd-color-icon-primary);
     }
 }
 
@@ -234,10 +234,9 @@ limitations under the License.
     }
 }
 
-.mx_LegacyRoomHeader_button--highlight,
+.mx_LegacyRoomHeader_button--highlight {
-.mx_LegacyRoomHeader_button:hover {
     &::before {
-        background-color: $accent !important;
+        background-color: var(--cpd-color-icon-primary) !important;
     }
 }
 

res/css/views/rooms/_MessageComposer.pcss

@@ -191,7 +191,7 @@ limitations under the License.
 }
 
 .mx_MessageComposer_button {
-    @mixin composerButton 50%, var(--cpd-color-icon-secondary), var(--cpd-color-bg-subtle-secondary);
+    @mixin composerButton 50%, var(--cpd-color-icon-primary), var(--cpd-color-bg-subtle-primary);
 
     &:last-child {
         margin-right: auto;

res/css/views/rooms/_NotificationBadge.pcss

@@ -39,7 +39,7 @@ limitations under the License.
             width: 8px;
             height: 8px;
             border-radius: 8px;
-            background-color: var(--cpd-color-text-primary);
+            background-color: var(--cpd-color-icon-primary);
 
             .mx_NotificationBadge_count {
                 display: none;
@@ -86,7 +86,8 @@ limitations under the License.
         .mx_NotificationBadge_count {
             font-size: $font-10px;
             line-height: $font-14px;
-            color: #fff; /* TODO: Variable */
+            font-weight: var(--cpd-font-weight-semibold);
+            color: var(--cpd-color-text-on-solid-primary);
         }
     }
 }

res/css/views/rooms/_RoomSublist.pcss

@@ -118,7 +118,7 @@ limitations under the License.
                 mask-position: center;
                 mask-size: contain;
                 mask-repeat: no-repeat;
-                background: $muted-fg-color;
+                background: var(--cpd-color-icon-secondary);
             }
         }
 
@@ -167,7 +167,7 @@ limitations under the License.
                     mask-position: center;
                     mask-size: contain;
                     mask-repeat: no-repeat;
-                    background-color: $tertiary-content;
+                    background-color: var(--cpd-color-icon-secondary);
                     mask-image: url("$(res)/img/feather-customised/chevron-down.svg");
                 }
 

res/css/views/rooms/_RoomTile.pcss

@@ -131,7 +131,7 @@ limitations under the License.
             mask-position: center;
             mask-size: contain;
             mask-repeat: no-repeat;
-            background: $primary-content;
+            background: var(--cpd-color-icon-primary);
         }
     }
 

res/css/views/rooms/_TopUnreadMessagesBar.pcss

@@ -40,7 +40,7 @@ limitations under the License.
     border-radius: 19px;
     box-sizing: border-box;
     background: $background;
-    border: 1.3px solid $muted-fg-color;
+    border: 1.3px solid var(--cpd-color-icon-tertiary);
     cursor: pointer;
 }
 
@@ -53,7 +53,7 @@ limitations under the License.
     mask-repeat: no-repeat;
     mask-size: 20px;
     mask-position: center;
-    background: $muted-fg-color;
+    background: var(--cpd-color-icon-tertiary);
 }
 
 .mx_TopUnreadMessagesBar_markAsRead {
@@ -61,7 +61,7 @@ limitations under the License.
     width: 18px;
     height: 18px;
     background: $background;
-    border: 1.3px solid $muted-fg-color;
+    border: 1.3px solid var(--cpd-color-icon-tertiary);
     border-radius: 10px;
     margin: 5px auto;
 }
@@ -75,5 +75,5 @@ limitations under the License.
     mask-repeat: no-repeat;
     mask-size: 10px;
     mask-position: 4px 4px;
-    background: $muted-fg-color;
+    background: var(--cpd-color-icon-tertiary);
 }

res/css/views/rooms/wysiwyg_composer/components/_Editor.pcss

@@ -115,7 +115,7 @@ limitations under the License.
             max-width: 100%;
             overflow: hidden;
 
-            color: $accent-fg-color;
+            color: var(--cpd-color-text-on-solid-primary);
             background-color: $pill-bg-color;
 
             /* ...with the overrides from _BasicMessageComposer.pcss */

res/themes/dark/css/_dark.pcss

@@ -22,7 +22,7 @@ $separator: var(--cpd-color-alpha-gray-400);
 /* ******************** */
 $roomlist-bg-color: rgba(38, 40, 45, 0.9);
 $roomsublist-skeleton-ui-bg: linear-gradient(180deg, $background 0%, #ffffff00 100%);
-$roomtile-default-badge-bg-color: $muted-fg-color;
+$roomtile-default-badge-bg-color: var(--cpd-color-icon-secondary);
 /* ******************** */
 
 /**
@@ -125,8 +125,8 @@ $roomheader-addroom-fg-color: $primary-content;
 
 /* Rich-text-editor */
 /* ******************** */
-$pill-bg-color: $room-highlight-color;
+$pill-bg-color: var(--cpd-color-gray-1000);
-$pill-hover-bg-color: #545a66;
+$pill-hover-bg-color: var(--cpd-color-gray-1100);
 /* ******************** */
 
 /* Inputs */
@@ -150,7 +150,7 @@ $dialog-close-external-color: $primary-content;
 /* ******************** */
 $system: var(--cpd-color-bg-subtle-secondary);
 $roomsublist-skeleton-ui-bg: linear-gradient(180deg, #3e444c 0%, #3e444c00 100%);
-$roomtile-default-badge-bg-color: $input-darker-fg-color;
+$roomtile-default-badge-bg-color: var(--cpd-color-icon-secondary);
 /* ******************** */
 
 /* Tabbed views */
@@ -199,10 +199,9 @@ $voice-record-icon-color: $quaternary-content;
 
 /* Bubble tiles */
 /* ******************** */
-$eventbubble-self-bg: #133a34;
+$eventbubble-self-bg: var(--cpd-color-green-300);
-$eventbubble-others-bg: #21262c;
+$eventbubble-others-bg: var(--cpd-color-gray-300);
-$eventbubble-bg-hover: #1c2026;
+$eventbubble-bg-hover: var(--cpd-color-bg-subtle-secondary);
-$eventbubble-reply-color: #c1c6cd;
 /* ******************** */
 
 /* Lightbox */

res/themes/legacy-dark/css/_legacy-dark.pcss

@@ -28,8 +28,8 @@ $light-fg-color: $header-panel-text-secondary-color;
 /* used for focusing form controls */
 $focus-bg-color: $room-highlight-color;
 
-$pill-bg-color: $room-highlight-color;
+$pill-bg-color: var(--cpd-color-gray-1000);
-$pill-hover-bg-color: #545a66;
+$pill-hover-bg-color: var(--cpd-color-gray-1100);
 
 /* informational plinth */
 $info-plinth-bg-color: $header-panel-bg-color;
@@ -217,7 +217,6 @@ $inlinecode-background-color: #2a3039;
 $eventbubble-self-bg: #14322e;
 $eventbubble-others-bg: $event-selected-color;
 $eventbubble-bg-hover: #1c2026;
-$eventbubble-reply-color: #c1c6cd;
 
 /* Location sharing */
 /* ******************** */

res/themes/legacy-light/css/_legacy-light.pcss

@@ -123,8 +123,8 @@ $rte-code-bg-color: rgba(0, 0, 0, 0.04);
 
 $header-panel-text-primary-color: #91a1c0;
 
-$pill-bg-color: #aaa;
+$pill-bg-color: var(--cpd-color-gray-1000);
-$pill-hover-bg-color: #ccc;
+$pill-hover-bg-color: var(--cpd-color-gray-1100);
 
 $topleftmenu-color: #212121;
 $roomheader-bg-color: $primary-bg-color;
@@ -311,7 +311,6 @@ $inlinecode-background-color: $header-panel-bg-color;
 $eventbubble-self-bg: #f0fbf8;
 $eventbubble-others-bg: $system;
 $eventbubble-bg-hover: #fafbfd;
-$eventbubble-reply-color: #c1c6cd;
 
 /* pinned events indicator */
 $pinned-color: $tertiary-content;

res/themes/light-custom/css/_custom.pcss

@@ -116,7 +116,6 @@ $settings-grey-fg-color: $primary-content;
 $eventbubble-self-bg: var(--eventbubble-self-bg, $eventbubble-self-bg);
 $eventbubble-others-bg: var(--eventbubble-others-bg, $eventbubble-others-bg);
 $eventbubble-bg-hover: var(--eventbubble-bg-hover, $eventbubble-bg-hover);
-$eventbubble-reply-color: var(--eventbubble-reply-color, $eventbubble-reply-color);
 
 $reaction-row-button-selected-bg-color: var(
     --reaction-row-button-selected-bg-color,

res/themes/light-high-contrast/css/_light-high-contrast.pcss

@@ -31,7 +31,6 @@ $button-secondary-bg-color: $accent-fg-color;
 $message-action-bar-fg-color: $primary-content;
 $voice-record-stop-border-color: $quinary-content;
 $voice-record-icon-color: $tertiary-content;
-$eventbubble-reply-color: $quaternary-content;
 $roomtopic-color: $secondary-content;
 
 /**

res/themes/light/css/_light.pcss

@@ -159,8 +159,8 @@ $roomheader-addroom-fg-color: #5c6470;
 
 /* Rich-text-editor */
 /* ******************** */
-$pill-bg-color: #aaa;
+$pill-bg-color: var(--cpd-color-gray-1000);
-$pill-hover-bg-color: #ccc;
+$pill-hover-bg-color: var(--cpd-color-gray-1100);
 $rte-bg-color: #e9e9e9;
 $rte-code-bg-color: rgba(0, 0, 0, 0.04);
 /* ******************** */
@@ -205,13 +205,13 @@ $imagebody-giflabel-color: $accent-fg-color;
 /* ******************** */
 $roomlist-bg-color: rgba(245, 245, 245, 0.9);
 $roomsublist-skeleton-ui-bg: linear-gradient(180deg, $background 0%, #ffffff00 100%);
-$roomtile-default-badge-bg-color: $muted-fg-color;
+$roomtile-default-badge-bg-color: var(--cpd-color-icon-secondary);
 /* ******************** */
 
 /* e2e */
 /* ******************** */
-$e2e-verified-color: var(--cpd-color-green-900);
+$e2e-verified-color: var(--cpd-color-icon-success-primary);
-$e2e-warning-color: var(--cpd-color-red-900);
+$e2e-warning-color: var(--cpd-color-icon-critical-primary);
 $e2e-verified-color-light: var(--cpd-color-green-300);
 $e2e-warning-color-light: var(--cpd-color-red-300);
 /* ******************** */
@@ -274,10 +274,9 @@ $voice-record-icon-color: $tertiary-content;
 
 /* Bubble tiles */
 /* ******************** */
-$eventbubble-self-bg: #e7f8f3;
+$eventbubble-self-bg: var(--cpd-color-green-300);
-$eventbubble-others-bg: #e8edf4;
+$eventbubble-others-bg: var(--cpd-color-gray-300);
-$eventbubble-bg-hover: #f6f7f8;
+$eventbubble-bg-hover: var(--cpd-color-bg-subtle-secondary);
-$eventbubble-reply-color: $quaternary-content;
 /* ******************** */
 
 /* Lightbox */

src/components/views/dialogs/security/AccessSecretStorageDialog.tsx

@@ -430,7 +430,7 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
                             onPrimaryButtonClick={this.onRecoveryKeyNext}
                             hasCancel={true}
                             cancelButton={_t("action|go_back")}
-                            cancelButtonClass="danger"
+                            cancelButtonClass="warning"
                             onCancel={this.onCancel}
                             focus={false}
                             primaryDisabled={!this.state.recoveryKeyValid}