imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Poll history - remove active development labs flag (#10357)

Browse source 
* add poll history tab to room settings

* test poll history in room settings

* remove posthog tracking for poll his

* remove labs flag for poll history

* i18n
This commit is contained in:
Kerry 2023-03-16 09:54:12 +13:00 • committed by GitHub
parent 31a959efe9
commit 2344eaab1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 33 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/components/views/dialogs/RoomSettingsDialog-test.tsx
View file

@ -89,10 +89,6 @@ describe("<RoomSettingsDialog />", () => {
describe("poll history", () => {
beforeEach(() => {
jest.spyOn(SettingsStore, "getValue").mockImplementation(
(settingName) => settingName === "feature_poll_history",
);
mockClient.getOrCreateFilter.mockResolvedValue("filterId");
});
it("renders poll history tab", () => {

15
test/components/views/dialogs/__snapshots__/RoomSettingsDialog-test.tsx.snap
View file

@ -62,6 +62,21 @@ NodeList [
Notifications
</span>
</div>,
<div
class="mx_AccessibleButton mx_TabbedView_tabLabel "
data-testid="settings-tab-ROOM_POLL_HISTORY_TAB"
role="button"
tabindex="0"
>
<span
class="mx_TabbedView_maskedIcon mx_RoomSettingsDialog_pollsIcon"
/>
<span
class="mx_TabbedView_tabLabel_text"
>
Polls history
</span>
</div>,
]
`;

4
test/components/views/right_panel/RoomSummaryCard-test.tsx
View file

@ -134,15 +134,13 @@ describe("<RoomSummaryCard />", () => {
});
describe("poll history", () => {
it("renders poll history option when feature is enabled", () => {
featureEnabledSpy.mockImplementation((feature) => feature === "feature_poll_history");
it("renders poll history option", () => {
const { getByText } = getComponent();
expect(getByText("Polls history")).toBeInTheDocument();
});
it("opens poll history dialog on button click", () => {
featureEnabledSpy.mockImplementation((feature) => feature === "feature_poll_history");
const { getByText } = getComponent();
fireEvent.click(getByText("Polls history"));

7
test/components/views/right_panel/__snapshots__/RoomSummaryCard-test.tsx.snap
View file

@ -83,6 +83,13 @@ exports[`<RoomSummaryCard /> renders the room summary 1`] = `
>
Files
</div>
<div
class="mx_AccessibleButton mx_BaseCard_Button mx_RoomSummaryCard_Button mx_RoomSummaryCard_icon_poll"
role="button"
tabindex="0"
>
Polls history
</div>
<div
class="mx_AccessibleButton mx_BaseCard_Button mx_RoomSummaryCard_Button mx_RoomSummaryCard_icon_export"
role="button"