Enable "jsx-a11y/alt-text" and "jsx-a11y/label-has-associated-control" lint rules (#10361)

* enable "jsx-a11y/alt-text" lint rule

* enable "jsx-a11y/label-has-associated-control"
This commit is contained in:
Kerry 2023-03-15 10:25:11 +13:00 committed by GitHub
parent e0e83bd81d
commit 209b65243a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 22 additions and 16 deletions

View file

@ -69,7 +69,7 @@ export class ExistingSource extends React.Component<ExistingSourceIProps> {
title={this.props.source.name}
onClick={this.onClick}
>
<img className={thumbnailClasses} src={this.props.source.thumbnailURL} />
<img alt={this.props.source.name} className={thumbnailClasses} src={this.props.source.thumbnailURL} />
<span className="mx_desktopCapturerSourcePicker_source_name">{this.props.source.name}</span>
</AccessibleButton>
);

View file

@ -72,7 +72,7 @@ export default function SearchWarning({ isRoomEncrypted, kind }: IProps): JSX.El
let text: ReactNode | undefined;
let logo: JSX.Element | undefined;
if (desktopBuilds?.get("available")) {
logo = <img src={desktopBuilds.get("logo")} />;
logo = <img alt={_t("Desktop app logo")} src={desktopBuilds.get("logo")} />;
const buildUrl = desktopBuilds.get("url");
switch (kind) {
case WarningKind.Files:

View file

@ -50,6 +50,8 @@ export default class MStickerBody extends MImageBody {
if (this.props.mxEvent.getContent().info?.[BLURHASH_FIELD]) return super.getPlaceholder(width, height);
return (
<img
aria-hidden
alt=""
className="mx_MStickerBody_placeholder"
src={require("../../../../res/img/icons-show-stickers.svg").default}
width="80"

View file

@ -79,21 +79,19 @@ export default class UrlPreviewSettings extends React.Component<IProps> {
if (SettingsStore.canSetValue("urlPreviewsEnabled", roomId, SettingLevel.ROOM)) {
previewsForRoom = (
<label>
<SettingsFlag
name="urlPreviewsEnabled"
level={SettingLevel.ROOM}
roomId={roomId}
isExplicit={true}
/>
</label>
<SettingsFlag
name="urlPreviewsEnabled"
level={SettingLevel.ROOM}
roomId={roomId}
isExplicit={true}
/>
);
} else {
let str = _td("URL previews are enabled by default for participants in this room.");
if (!SettingsStore.getValueAt(SettingLevel.ROOM, "urlPreviewsEnabled", roomId, /*explicit=*/ true)) {
str = _td("URL previews are disabled by default for participants in this room.");
}
previewsForRoom = <label>{_t(str)}</label>;
previewsForRoom = <div>{_t(str)}</div>;
}
} else {
previewsForAccount = _t(
@ -127,7 +125,7 @@ export default class UrlPreviewSettings extends React.Component<IProps> {
return (
<SettingsFieldset legend={_t("URL Previews")} description={description}>
{previewsForRoom}
<label>{previewsForRoomAccount}</label>
{previewsForRoomAccount}
</SettingsFieldset>
);
}

View file

@ -161,7 +161,12 @@ export default class EntityTile extends React.PureComponent<IProps, IState> {
if (this.props.showInviteButton) {
inviteButton = (
<div className="mx_EntityTile_invite">
<img src={require("../../../../res/img/plus.svg").default} width="16" height="16" />
<img
alt={_t("Invite")}
src={require("../../../../res/img/plus.svg").default}
width="16"
height="16"
/>
</div>
);
}

View file

@ -538,6 +538,8 @@ export class MessageComposer extends React.Component<IProps, IState> {
<div className="mx_MessageComposer_replaced_wrapper" key="room_replaced">
<div className="mx_MessageComposer_replaced_valign">
<img
aria-hidden
alt=""
className="mx_MessageComposer_roomReplaced_icon"
src={require("../../../../res/img/room_replaced.svg").default}
/>