imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update the TAC indicator on event decryption (#12243)

Browse source 
* Update the TAC indicator on event decryption

But throttled so we don't kill the client

Fixes https://github.com/element-hq/element-web/issues/26990

* Just pass the function
This commit is contained in:
David Baker 2024-02-13 10:58:17 +00:00 • committed by GitHub
parent 36c07be889
commit 203c15f205
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 148 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/components/views/spaces/threads-activity-centre/useUnreadThreadRooms.ts
View file

@ -16,8 +16,9 @@
* /
*/
import { useEffect, useState } from "react";
import { ClientEvent, MatrixClient, Room } from "matrix-js-sdk/src/matrix";
import { useCallback, useEffect, useState } from "react";
import { ClientEvent, MatrixClient, MatrixEventEvent, Room } from "matrix-js-sdk/src/matrix";
import { throttle } from "lodash";
import { doesRoomHaveUnreadThreads } from "../../../../Unread";
import { NotificationLevel } from "../../../../stores/notifications/NotificationLevel";
@ -27,6 +28,8 @@ import { useMatrixClientContext } from "../../../../contexts/MatrixClientContext
import { useEventEmitter } from "../../../../hooks/useEventEmitter";
import { VisibilityProvider } from "../../../../stores/room-list/filters/VisibilityProvider";
const MIN_UPDATE_INTERVAL_MS = 500;
type Result = {
greatestNotificationLevel: NotificationLevel;
rooms: Array<{ room: Room; notificationLevel: NotificationLevel }>;
@ -44,17 +47,33 @@ export function useUnreadThreadRooms(forceComputation: boolean): Result {
const [result, setResult] = useState<Result>({ greatestNotificationLevel: NotificationLevel.None, rooms: [] });
// Listen to sync events to update the result
useEventEmitter(mxClient, ClientEvent.Sync, () => {
const doUpdate = useCallback(() => {
setResult(computeUnreadThreadRooms(mxClient, msc3946ProcessDynamicPredecessor));
});
}, [mxClient, msc3946ProcessDynamicPredecessor]);
// The exhautive deps lint rule can't compute dependencies here since it's not a plain inline func.
// We make this as simple as possible so its only dep is doUpdate itself.
// eslint-disable-next-line react-hooks/exhaustive-deps
const scheduleUpdate = useCallback(
throttle(doUpdate, MIN_UPDATE_INTERVAL_MS, {
leading: false,
trailing: true,
}),
[doUpdate],
);
// Listen to sync events to update the result
useEventEmitter(mxClient, ClientEvent.Sync, scheduleUpdate);
// and also when events get decrypted, since this will often happen after the sync
// event and may change notifications.
useEventEmitter(mxClient, MatrixEventEvent.Decrypted, scheduleUpdate);
// Force the list computation
useEffect(() => {
if (forceComputation) {
setResult(computeUnreadThreadRooms(mxClient, msc3946ProcessDynamicPredecessor));
doUpdate();
}
}, [mxClient, msc3946ProcessDynamicPredecessor, forceComputation]);
}, [doUpdate, forceComputation]);
return result;
}