imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: Space scope header overflow (#11933)

Browse source 
* fix spacing for scope header

* extract scope header into component, apply line clamp

* update ThirdPartyMemberInfo styles

* pass onClose to ThirdPartyRoomMemberInfo

* rethemendex

* add View3pidInvite to actions enum, replace uses

* extract out action handler

* push card instead, test

* comment

* reinstate data-testid

* fix typo in styles
This commit is contained in:
Kerry 2023-11-29 21:25:34 +13:00 • committed by GitHub
parent 4d0a34bb26
commit 1ffa1c9c18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 188 additions and 221 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/components/views/right_panel/__snapshots__/UserInfo-test.tsx.snap
View file

@ -86,9 +86,7 @@ exports[`<UserInfo /> with crypto enabled renders <BasicUserInfo /> 1`] = `
/>
<div
class="mx_BaseCard_headerProp"
>
<span />
</div>
/>
</div>
<div
class="mx_AutoHideScrollbar"

76
test/components/views/rooms/__snapshots__/ThirdPartyMemberInfo-test.tsx.snap
View file

@ -3,26 +3,40 @@
exports[`<ThirdPartyMemberInfo /> should render invite 1`] = `
<div>
<div
class="mx_MemberInfo"
role="tabpanel"
class="mx_BaseCard"
>
<div
class="mx_MemberInfo_name"
class="mx_BaseCard_header"
>
<div
class="mx_AccessibleButton mx_MemberInfo_cancel"
role="button"
tabindex="0"
title="Close"
class="mx_BaseCard_headerProp"
/>
<h2>
bob@bob.com
</h2>
</div>
<div
class="mx_MemberInfo_container mx_MemberInfo_container--profile"
class="mx_AutoHideScrollbar"
tabindex="-1"
>
Invited by Alice DisplayName
<div
class="mx_Flex mx_ThirdPartyMemberInfo"
style="--mx-flex-display: flex; --mx-flex-direction: column; --mx-flex-align: start; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-4x);"
>
<section
class="mx_Flex"
style="--mx-flex-display: flex; --mx-flex-direction: column; --mx-flex-align: start; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-2x);"
>
<span
class="_typography_yh5dq_162 _font-body-lg-semibold_yh5dq_83"
role="heading"
>
bob@bob.com
</span>
<span
class="_typography_yh5dq_162 _font-body-md-regular_yh5dq_59"
>
Invited by Alice DisplayName
</span>
</section>
</div>
</div>
</div>
</div>
@ -31,26 +45,40 @@ exports[`<ThirdPartyMemberInfo /> should render invite 1`] = `
exports[`<ThirdPartyMemberInfo /> should render invite when room in not available 1`] = `
<div>
<div
class="mx_MemberInfo"
role="tabpanel"
class="mx_BaseCard"
>
<div
class="mx_MemberInfo_name"
class="mx_BaseCard_header"
>
<div
class="mx_AccessibleButton mx_MemberInfo_cancel"
role="button"
tabindex="0"
title="Close"
class="mx_BaseCard_headerProp"
/>
<h2>
bob@bob.com
</h2>
</div>
<div
class="mx_MemberInfo_container mx_MemberInfo_container--profile"
class="mx_AutoHideScrollbar"
tabindex="-1"
>
Invited by Alice DisplayName
<div
class="mx_Flex mx_ThirdPartyMemberInfo"
style="--mx-flex-display: flex; --mx-flex-direction: column; --mx-flex-align: start; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-4x);"
>
<section
class="mx_Flex"
style="--mx-flex-display: flex; --mx-flex-direction: column; --mx-flex-align: start; --mx-flex-justify: start; --mx-flex-gap: var(--cpd-space-2x);"
>
<span
class="_typography_yh5dq_162 _font-body-lg-semibold_yh5dq_83"
role="heading"
>
bob@bob.com
</span>
<span
class="_typography_yh5dq_162 _font-body-md-regular_yh5dq_59"
>
Invited by Alice DisplayName
</span>
</section>
</div>
</div>
</div>
</div>