Conform more code to strictNullChecks (#10374)

* Apply `strictNullChecks` to `src/components/views/room_settings/*`

* Restore tsconfig.json

* Conform more code to `strictNullChecks`

* Iterate

* Update matrix-widget-api

* Conform more code to `strictNullChecks`

src/voice-broadcast/components/molecules/ConfirmListenBroadcastStopCurrent.tsx

@@ -14,7 +14,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { defer } from "matrix-js-sdk/src/utils";
 import React from "react";
 
 import BaseDialog from "../../../components/views/dialogs/BaseDialog";
@@ -46,11 +45,7 @@ export const ConfirmListenBroadcastStopCurrentDialog: React.FC<Props> = ({ onFin
 };
 
 export const showConfirmListenBroadcastStopCurrentDialog = async (): Promise<boolean> => {
-    const { promise, resolve } = defer<boolean>();
-
-    Modal.createDialog(ConfirmListenBroadcastStopCurrentDialog, {
-        onFinished: resolve,
-    });
-
-    return promise;
+    const { finished } = Modal.createDialog(ConfirmListenBroadcastStopCurrentDialog);
+    const [confirmed] = await finished;
+    return !!confirmed;
 };

src/voice-broadcast/hooks/useVoiceBroadcastPlayback.ts

@@ -35,7 +35,7 @@ export const useVoiceBroadcastPlayback = (
         position: number;
         timeLeft: number;
     };
-    sender: RoomMember;
+    sender: RoomMember | null;
     liveness: VoiceBroadcastLiveness;
     playbackState: VoiceBroadcastPlaybackState;
     toggle(): void;

src/voice-broadcast/hooks/useVoiceBroadcastRecording.tsx

@@ -44,7 +44,7 @@ const showStopBroadcastingDialog = async (): Promise<boolean> => {
         button: _t("Yes, stop broadcast"),
     });
     const [confirmed] = await finished;
-    return confirmed;
+    return !!confirmed;
 };
 
 export const useVoiceBroadcastRecording = (
@@ -54,7 +54,7 @@ export const useVoiceBroadcastRecording = (
     timeLeft: number;
     recordingState: VoiceBroadcastRecordingState;
     room: Room;
-    sender: RoomMember;
+    sender: RoomMember | null;
     stopRecording(): void;
     toggleRecording(): void;
 } => {

src/voice-broadcast/index.ts

@@ -32,7 +32,7 @@ export * from "./components/atoms/VoiceBroadcastHeader";
 export * from "./components/atoms/VoiceBroadcastPlaybackControl";
 export * from "./components/atoms/VoiceBroadcastRecordingConnectionError";
 export * from "./components/atoms/VoiceBroadcastRoomSubtitle";
-export * from "./components/molecules/ConfirmListeBroadcastStopCurrent";
+export * from "./components/molecules/ConfirmListenBroadcastStopCurrent";
 export * from "./components/molecules/VoiceBroadcastPlaybackBody";
 export * from "./components/molecules/VoiceBroadcastSmallPlaybackBody";
 export * from "./components/molecules/VoiceBroadcastPreRecordingPip";