imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removing timing/performance tracking on room list store

Browse source 
This was used to verify the fix was actually making improvements and can be safely taken out.
This commit is contained in:
Travis Ralston 2018-11-01 16:30:48 -06:00
parent 0c7aadb92b
commit 122868e32f
1 changed files with 1 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

55
src/stores/RoomListStore.js
View file

@ -227,20 +227,12 @@ class RoomListStore extends Store {
// thousand times. // thousand times.
const pinUnread = SettingsStore.getValue("pinUnreadRooms"); const pinUnread = SettingsStore.getValue("pinUnreadRooms");
const pinMentioned = SettingsStore.getValue("pinMentionedRooms"); const pinMentioned = SettingsStore.getValue("pinMentionedRooms");
this._timings = {};
Object.keys(lists).forEach((listKey) => { Object.keys(lists).forEach((listKey) => {
let comparator; let comparator;
switch (RoomListStore._listOrders[listKey]) { switch (RoomListStore._listOrders[listKey]) {
case "recent": case "recent":
comparator = (roomA, roomB) => { comparator = (roomA, roomB) => {
this._timings["overall_" + roomA.roomId + "_" + roomB.roomId] = { return this._recentsComparator(roomA, roomB, pinUnread, pinMentioned);
type: "overall",
start: performance.now(),
end: 0,
};
const ret = this._recentsComparator(roomA, roomB, pinUnread, pinMentioned);
this._timings["overall_" + roomA.roomId + "_" + roomB.roomId].end = performance.now();
return ret;
}; };
break; break;
case "manual": case "manual":
@ -251,32 +243,6 @@ class RoomListStore extends Store {
lists[listKey].sort(comparator); lists[listKey].sort(comparator);
}); });
// Combine the samples for performance metrics
const samplesByType = {};
for (const sampleName of Object.keys(this._timings)) {
const sample = this._timings[sampleName];
if (!samplesByType[sample.type]) samplesByType[sample.type] = {
min: 999999999,
max: 0,
count: 0,
total: 0,
};
const record = samplesByType[sample.type];
const duration = sample.end - sample.start;
if (duration < record.min) record.min = duration;
if (duration > record.max) record.max = duration;
record.count++;
record.total += duration;
}
for (const category of Object.keys(samplesByType)) {
const {min, max, count, total} = samplesByType[category];
const average = total / count;
console.log(`RoomListSortPerf : type=${category} min=${min} max=${max} total=${total} samples=${count} average=${average}`);
}
this._setState({ this._setState({
lists, lists,
ready: true, // Ready to receive updates via Room.tags events ready: true, // Ready to receive updates via Room.tags events
@ -347,29 +313,16 @@ class RoomListStore extends Store {
} }
_recentsComparator(roomA, roomB, pinUnread, pinMentioned) { _recentsComparator(roomA, roomB, pinUnread, pinMentioned) {
//console.log("Comparing " + roomA.roomId + " with " + roomB.roomId +" || pinUnread=" + pinUnread +" pinMentioned="+pinMentioned);
// We try and set the ordering to be Mentioned > Unread > Recent // We try and set the ordering to be Mentioned > Unread > Recent
// assuming the user has the right settings, of course. // assuming the user has the right settings, of course.
this._timings["timestamp_" + roomA.roomId + "_" + roomB.roomId] = {
type: "timestamp",
start: performance.now(),
end: 0,
};
const timestampA = this._getRoomState(roomA, "timestamp"); const timestampA = this._getRoomState(roomA, "timestamp");
const timestampB = this._getRoomState(roomB, "timestamp"); const timestampB = this._getRoomState(roomB, "timestamp");
const timestampDiff = timestampB - timestampA; const timestampDiff = timestampB - timestampA;
this._timings["timestamp_" + roomA.roomId + "_" + roomB.roomId].end = performance.now();
if (pinMentioned) { if (pinMentioned) {
this._timings["mentioned_" + roomA.roomId + "_" + roomB.roomId] = {
type: "mentioned",
start: performance.now(),
end: 0,
};
const mentionsA = this._getRoomState(roomA, "notifications"); const mentionsA = this._getRoomState(roomA, "notifications");
const mentionsB = this._getRoomState(roomB, "notifications"); const mentionsB = this._getRoomState(roomB, "notifications");
this._timings["mentioned_" + roomA.roomId + "_" + roomB.roomId].end = performance.now();
if (mentionsA && !mentionsB) return -1; if (mentionsA && !mentionsB) return -1;
if (!mentionsA && mentionsB) return 1; if (!mentionsA && mentionsB) return 1;
@ -381,14 +334,8 @@ class RoomListStore extends Store {
} }
if (pinUnread) { if (pinUnread) {
this._timings["unread_" + roomA.roomId + "_" + roomB.roomId] = {
type: "unread",
start: performance.now(),
end: 0,
};
const unreadA = this._getRoomState(roomA, "unread"); const unreadA = this._getRoomState(roomA, "unread");
const unreadB = this._getRoomState(roomB, "notifications"); const unreadB = this._getRoomState(roomB, "notifications");
this._timings["unread_" + roomA.roomId + "_" + roomB.roomId].end = performance.now();
if (unreadA && !unreadB) return -1; if (unreadA && !unreadB) return -1;
if (!unreadA && unreadB) return 1; if (!unreadA && unreadB) return 1;